From 5545cf2860ef3f2d58b2a0c9dccccf5f21c1ed1f Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 30 Sep 2020 15:46:45 +0000 Subject: [PATCH] Bug 26576: Subfield descriptions on authority detail view are cut off This patch corrects the authority detail view on the staff interface so that subfield descriptions are not longer output as truncated strings. For instance, before this patch the subfield description for 035$a would be "System control numbe" After the patch it should be "System control number." Based on the assumption that the subfield descriptions were truncated at some point for readability reasons I've also made some style changes intended to improve the readability of the page. To test, apply the patch and go to Authorities. - Search for and view the details for an authority. - On the authority detail page, confirm that subfield descriptions are shown in full. - Confirm that the style changes look good and make the data more readable. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- .../prog/en/modules/authorities/detail.tt | 98 ++++++++++++++----- 1 file changed, 73 insertions(+), 25 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt index 2afd64247c..2670138b72 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt @@ -11,6 +11,45 @@ [% END %] [% INCLUDE 'doc-head-close.inc' %] +[% Asset.css("css/addbiblio.css") | $raw %] +[% FILTER collapse %] + +[% END %] @@ -64,35 +103,44 @@ [% FOREACH innerloo IN BIG_LOO.innerloop %] [% IF ( innerloo.tag_number ) %]
-
- [% innerloo.tag_number | html %] - [% IF (innerloo.defined("ind1") ) %] - [% innerloo.ind1 | html %][% innerloo.ind2 | html %] - [% END %] - [% IF (innerloo.tag_desc) %] - [% innerloo.tag_desc | html %][% END %] -
+
+ [% innerloo.tag_number | html %] + [% IF (innerloo.defined("ind1") ) %] + [% innerloo.ind1 | html %][% innerloo.ind2 | html %] + [% END %] + [% IF (innerloo.tag_desc) %] + - [% innerloo.tag_desc | html %] + [% END %] +
[% ELSE %]
[% END %] [% FOREACH subfiel IN innerloo.subfield %] -

- - [% IF ( subfiel.is_url ) %] - [% subfiel.marc_value | html %] - [% ELSE %] - [% subfiel.marc_value | html %] - [% END %] - [% IF ( subfiel.link ) %] - - - - [% END %] - [% IF ( subfiel.authority ) %] - Auth - [% END %] -

+
+
+ [% UNLESS ( subfiel.hide_marc ) %] + [% subfiel.marc_subfield | html %] + [% END %] + [% subfiel.long_desc | html %] +
+
+ + [% IF ( subfiel.is_url ) %] + [% subfiel.marc_value | html %] + [% ELSE %] + [% subfiel.marc_value | html %] + [% END %] + + [% IF ( subfiel.link ) %] + + + + [% END %] + [% IF ( subfiel.authority ) %] + Auth + [% END %] +
+
[% END %]
[% END %] -- 2.39.5