From 5db28348ea219dff070acc221f151ff8719d77ba Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Mon, 9 Oct 2023 21:29:13 +0000
Subject: [PATCH] Bug 34300: (QA follow-up) Add permission check and fix
 missing table cells

* Changes text from "Place a hold on order" to the more common "Place hold"
* Adds permission check on reserveforothers.
* We were missing table cells in the footer rows of the table.

I would have liked to hide the column for someone missing permissions,
but I failed to get the datatable configuration right with the export
and column configuration settings.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../intranet-tmpl/prog/en/modules/acqui/basket.tt    | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
index ceceeeb5fb..78e61ad302 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
@@ -482,7 +482,7 @@
                                                     [% IF Koha.Preference('EDIFACT') && ediaccount %]
                                                         <th>Supplier report</th>
                                                     [% END %]
-                                                    <th>Place hold</th>
+                                                    <th class="NoSort">Place hold</th>
                                                     [% IF ( active ) %]
                                                         [% UNLESS ( closedate ) %]
                                                             <th class="NoSort">Modify</th>
@@ -516,6 +516,7 @@
                                                         [% IF Koha.Preference('EDIFACT') && ediaccount %]
                                                             <th>&nbsp;</th>
                                                         [% END %]
+                                                        <th>&nbsp;</th>
                                                         [% IF ( active ) %]
                                                             [% UNLESS ( closedate ) %]
                                                                 <th>&nbsp;</th>
@@ -547,6 +548,7 @@
                                                     [% IF Koha.Preference('EDIFACT') && ediaccount %]
                                                         <th>&nbsp;</th>
                                                     [% END %]
+                                                    <th>&nbsp;</th>
                                                     [% IF ( active ) %]
                                                         [% UNLESS ( closedate ) %]
                                                             <th>&nbsp;</th>
@@ -678,9 +680,11 @@
                                                             <td>[% books_loo.suppliers_report | html %]</td>
                                                         [% END %]
                                                         <td>
-                                                            <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% books_loo.biblionumber | uri %]">
-                                                                Place a hold on the order
-                                                            </a>
+                                                            [% IF ( CAN_user_reserveforothers_place_holds ) %]
+                                                                <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% books_loo.biblionumber | uri %]">
+                                                                    Place hold
+                                                                </a>
+                                                            [% END %]
                                                         </td>
                                                         [% IF ( active ) %]
                                                             [% UNLESS ( closedate ) %]
-- 
2.20.1