From 5fbdfa08cc0c5857477b6607ae3b3b16fcab2ab8 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 1 Nov 2022 08:29:23 +0100
Subject: [PATCH] Bug 32030: Add 'Loading' to EHoldingsLocalPackageAgreements

To prevent the cypress test to fail random, and it also remove a blink
code/value in the dropdown list, which is nicer for the end-user.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../ERM/EHoldingsLocalPackageAgreements.vue           | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageAgreements.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageAgreements.vue
index 2986fbc91f..29dcd846cc 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageAgreements.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageAgreements.vue
@@ -1,7 +1,10 @@
 <template>
     <fieldset class="rows" id="package_agreements">
         <legend>{{ $__("Agreements") }}</legend>
+
+        <div v-if="!initialized">{{ $__("Loading") }}</div>
         <fieldset
+            v-else
             :id="`package_agreement_${counter}`"
             class="rows"
             v-for="(package_agreement, counter) in package_agreements"
@@ -40,12 +43,14 @@
             </ol>
         </fieldset>
         <a
-            v-if="agreements.length"
+            v-if="initialized && agreements.length"
             class="btn btn-default"
             @click="addAgreement"
             ><font-awesome-icon icon="plus" /> {{ $__("Add new agreement") }}</a
         >
-        <span v-else>{{ $__("There are no agreements created yet") }}</span>
+        <span v-else-if="initialized">{{
+            $__("There are no agreements created yet")
+        }}</span>
     </fieldset>
 </template>
 
@@ -56,11 +61,13 @@ export default {
     data() {
         return {
             agreements: [],
+            initialized: false,
         }
     },
     beforeCreate() {
         fetchAgreements().then(agreements => {
             this.agreements = agreements
+            this.initialized = true
         })
     },
     methods: {
-- 
2.39.5