From 60a0c1c51cc4667eefa62232d7a45a823168a378 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 21 Feb 2020 10:31:54 +0100 Subject: [PATCH] Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page) To prevent invalid values in this pref (and so on the server), we should make this input readonly on the syspref page. The sysprefs related to Hea should be edited from the dedicated page, so also adding a note about that. Test plan: Search syspref with "UsageStats" Notice the note about the admin page Notice the UsageStatsGeolocation input is now readonly (and resized, to display the whole value when filled) Signed-off-by: Maryse Simard Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson --- .../intranet-tmpl/prog/en/modules/admin/preferences.tt | 6 +++++- .../prog/en/modules/admin/preferences/admin.pref | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt index 764f1645d9..38ecd63e1c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt @@ -79,7 +79,11 @@ [% IF ( CHUNK.type_text ) %] [% CHUNK.contents | $raw %] [% ELSIF ( CHUNK.type_input ) %] - [% IF ( CHUNK.dateinput ) %][% INCLUDE 'date-format.inc' %][% END %] + [% IF CHUNK.name == 'UsageStatsGeolocation' %] + [% IF ( CHUNK.dateinput ) %][% INCLUDE 'date-format.inc' %][% END %] + [% ELSE %] + [% IF ( CHUNK.dateinput ) %][% INCLUDE 'date-format.inc' %][% END %] + [% END %] [% ELSIF ( CHUNK.type_select ) %]