From 692014c817b58876042ab03d71bde0c2cce7e571 Mon Sep 17 00:00:00 2001 From: Marc Date: Fri, 7 Oct 2016 11:03:45 +0200 Subject: [PATCH] Bug 11217: The # in accountlines descriptions makes them un-writeoffable This patch adds escaping to url params in mambers/pay.pl To test: - Apply patch - Go to Home > Patrons > Manual invoice and create an invoice with a description containing a # - Go to tab "Pay fines" - Write off the fine Expected result: Fine is written off and does no longer display in pay tab. Signed-off-by: Claire Gravely Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher --- members/pay.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/members/pay.pl b/members/pay.pl index 6ee652cd9c..bfca78b80e 100755 --- a/members/pay.pl +++ b/members/pay.pl @@ -43,6 +43,7 @@ use C4::Members::Attributes qw(GetBorrowerAttributes); use Koha::Patron::Images; use Koha::Patron::Categories; +use URI::Escape; our $input = CGI->new; @@ -174,8 +175,8 @@ sub redirect_to_paycollect { $redirect .= get_for_redirect( 'amount', "amount$line_no", 1 ); $redirect .= get_for_redirect( 'amountoutstanding', "amountoutstanding$line_no", 1 ); - $redirect .= get_for_redirect( 'description', "description$line_no", 0 ); - $redirect .= get_for_redirect( 'title', "title$line_no", 0 ); + $redirect .= uri_escape_utf8( get_for_redirect( 'description', "description$line_no", 0 ) ); + $redirect .= uri_escape_utf8( get_for_redirect( 'title', "title$line_no", 0 ) ); $redirect .= get_for_redirect( 'itemnumber', "itemnumber$line_no", 0 ); $redirect .= get_for_redirect( 'notify_id', "notify_id$line_no", 0 ); $redirect .= get_for_redirect( 'notify_level', "notify_level$line_no", 0 ); -- 2.39.5