From 6b31947c3bb6517ecdc7d21440ba79895c270749 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 16 Sep 2015 13:56:23 +1200 Subject: [PATCH] Bug 15035: Anti-spam for opac-suggestions - FOLLOW-UP to test this patch... 1/ enable 'suggestion' and 'AnonSuggestions' sysprefs 2/ edit the koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt file, to reveal the hidden 'negcap' field replace line 87 opac-suggestions.tt, from...
  • to ...
  • 3/ attempt to add another suggestion, and populate the 'negcap' field adding the suggestion is supposed to fail, but actually succeeds!? :/ 4/ apply patch 5/ repeat step 3, suggestion attempt should fail as expected modified: opac-suggestions.pl Signed-off-by: Bernardo Gonzalez Kriegel Confirmed insertion with negcap before patch. With negcap value suggestion fails silently Without negcap suggestion is inserted No errors Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- opac/opac-suggestions.pl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl index 6b7f8d4770..78b409f890 100755 --- a/opac/opac-suggestions.pl +++ b/opac/opac-suggestions.pl @@ -35,7 +35,6 @@ use Koha::DateUtils qw( dt_from_string ); my $input = new CGI; my $op = $input->param('op'); my $suggestion = $input->Vars; -delete $suggestion->{negcap}; my $negcaptcha = $input->param('negcap'); my $suggested_by_anyone = $input->param('suggested_by_anyone') || 0; @@ -43,6 +42,10 @@ my $suggested_by_anyone = $input->param('suggested_by_anyone') || 0; if ($negcaptcha ) { print $input->redirect("/cgi-bin/koha/opac-suggestions.pl"); exit; +} else { + # don't pass 'negcap' column to DB, else DBI::Class will error + # DBIx::Class::Row::store_column(): No such column 'negcap' on Koha::Schema::Result::Suggestion at Koha/C4/Suggestions.pm + delete $suggestion->{negcap}; } #If suggestions are turned off we redirect to 404 error. This will also redirect guest suggestions -- 2.39.5