From 71d3b84b054dabe9a547971b7ce1f3efbee2e568 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@biblibre.com>
Date: Tue, 7 Apr 2015 17:03:46 +0200
Subject: [PATCH] Bug 10388: Does not display 'null' after editing an item on
 receiving

After editing an item on receiving, 'null' is displayed if no value is
defined for a field. It should be blank.

Test plan:
0/ Set AcqCreateItem to 'ordering'
1/ Go on the receipt page page
2/ Edit an item
3/ Does not fill all values
4/ Confirm that undefined values are replaced with an empty string

NOTE: I think you meant receive. Editing requires at least clicking
      the dropdown value, even if you don't change it before
      clicking save. null's appeared. Post patch application was
      able to get nulls to disappear. :)

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 65405c5a96207623b3b30997b7c93f02fbcfe2f7)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
index 014f39bdcd..08565a630f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
@@ -69,7 +69,9 @@
                             var tds = $("#item_"+itemnumber+" td");
                             for(var i=2; i<tds.length; i++) {
                                 var column = items_columns[i];
-                                $(tds[i]).text(item[column]);
+                                var text = item[column];
+                                if ( text == null ) text = '';
+                                $(tds[i]).text(text);
                             }
                         }
                     );
-- 
2.39.5