From 78c9815c7d425836e5b7fbbc749cc0b59a898277 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Wed, 16 May 2018 01:05:07 +0000
Subject: [PATCH] Bug 9968: Fix wrong index for Standard number in advanced and
 label search

'Standard number' indicates that you can search ISBN, ISSN and other
standard numbers, but we are using the wrong index and only get a
very limited search for biblionumber instead.

This patch changes the index from sn to ident.

To test:
- Check both staff and OPAC advanced search:
  - Search for Standard number = ISBN
  - Search for Standard number = ISSN
  Both should work.
  Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences
- Check the label creator
  - Add a new batch
  - Use 'add items' option and search for Standard number

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 09a7d37d53a87e35f2151e00200995ab3dfa3896)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit d341326362656853d0f8d371bd7d685b9c4266d7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt    | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
index 95d368411a..1aff1a4091 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
@@ -23,9 +23,9 @@
     <option value="bc">Barcode</option>
     <option value="location">Shelving location</option>
     [% IF ( Koha.Preference('IntranetNumbersPreferPhrase') ) %]
-    <option value="sn,phr">Standard number</option>
+    <option value="ident,phr">Standard number</option>
     [% ELSE %]
-    <option value="sn">Standard number</option>
+    <option value="ident">Standard number</option>
     [% END %]
     <option value="nb">&nbsp;&nbsp;&nbsp;&nbsp; ISBN</option>
     <option value="ns">&nbsp;&nbsp;&nbsp;&nbsp; ISSN</option>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt
index d9d52357ad..3dade265f1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt
@@ -32,7 +32,7 @@ to add to Batch [% batch_id %]
 [% IF idx == 'yr'  %]<option value="yr" selected="selected">Publication date</option>
 [% ELSE %]<option value="yr">Publication date</option>[% END %]
 
-[% IF idx == 'sn' %]<option value="sn" selected="selected">Standard number</option>
+[% IF idx == 'sn' %]<option value="ident" selected="selected">Standard number</option>
 [% ELSE %]<option value="sn">Standard number</option>[% END %]
 
 [% IF idx == 'nb' %]<option value="nb" selected="selected">ISBN</option>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
index 46e4ab4ede..d62cd08b2b 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
@@ -80,9 +80,9 @@
                                         <option value="pl,wrdl">Publisher location</option>
                                         [% IF ( expanded_options ) %]
                                             [% IF ( Koha.Preference('OPACNumbersPreferPhrase') ) %]
-                                                <option value="sn,phr">Standard number</option>
+                                                <option value="ident,phr">Standard number</option>
                                             [% ELSE %]
-                                                <option value="sn">Standard number</option>
+                                                <option value="ident">Standard number</option>
                                             [% END %]
                                             <option value="nb">&nbsp;&nbsp;&nbsp;&nbsp; ISBN</option>
                                             <option value="ns">&nbsp;&nbsp;&nbsp;&nbsp; ISSN</option>
-- 
2.39.2