From 7bcd2982bba300a9c4d3da3e553730c975bad16f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bj=C3=B6rn=20Nyl=C3=A9n?= Date: Mon, 3 May 2021 13:13:25 +0200 Subject: [PATCH] Bug 26587: Cache libraries in Koha/Template/Plugins/Branches.pm to improve performance MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch caches the Koha::Library object in a hashmap in the Branches object (GetName, GetURL) to avoid multiple database lookups while looping many items. To test: 1. Have a biblio with many items (1000's). 2. View in staff (detail.pl) and opac (opac-detail.pl). Note how long it takes to load. 3. Apply patch. 4. Repeat 2. Note that pages load faster. Sponsored-by: Lund University Library JK: replaced tab indendation with spaces Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall --- Koha/Template/Plugin/Branches.pm | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/Koha/Template/Plugin/Branches.pm b/Koha/Template/Plugin/Branches.pm index 92c83be68c..c4f552a71f 100644 --- a/Koha/Template/Plugin/Branches.pm +++ b/Koha/Template/Plugin/Branches.pm @@ -27,11 +27,24 @@ use C4::Koha; use C4::Context; use Koha::Libraries; +sub new { + my ($self) = shift; + my (@params) = @_; + $self = $self->SUPER::new(@params); + #Initialize a cache of libraries for lookups of names,urls etc. + $self->{libraries} = {}; + + return $self; +} + sub GetName { my ( $self, $branchcode ) = @_; - my $l = Koha::Libraries->find($branchcode); - return $l ? $l->branchname : q{}; + unless (exists $self->{libraries}->{$branchcode} ){ + my $l = Koha::Libraries->find($branchcode); + $self->{libraries}->{$branchcode} = $l if $l; + } + return $self->{libraries}->{$branchcode} ? $self->{libraries}->{$branchcode}->branchname : q{}; } sub GetLoggedInBranchcode { @@ -49,11 +62,11 @@ sub GetLoggedInBranchname { sub GetURL { my ( $self, $branchcode ) = @_; - my $query = "SELECT branchurl FROM branches WHERE branchcode = ?"; - my $sth = C4::Context->dbh->prepare($query); - $sth->execute($branchcode); - my $b = $sth->fetchrow_hashref(); - return $b->{branchurl}; + unless (exists $self->{libraries}->{$branchcode} ){ + my $l = Koha::Libraries->find($branchcode); + $self->{libraries}->{$branchcode} = $l if $l; + } + return $self->{libraries}->{$branchcode} ? $self->{libraries}->{$branchcode}->branchurl : q{}; } sub all { -- 2.39.5