From 7e577fe266d2f775e15cdaed60951ca6de86ad2f Mon Sep 17 00:00:00 2001
From: Katrin Fischer <Katrin.Fischer.83@web.de>
Date: Sun, 22 Nov 2015 03:38:30 +0100
Subject: [PATCH] Bug 12152: Holds to pull report - Show branch names and item
 type descriptions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

The 'Holds to pull' report shows branch and itemtype codes without
this patch. With the patch, names and descriptions should display.

To test:
- Make sure there are some holds for available items in your system
- Go to Circulation > Holds to pull
- Verify changes mentioned above in the list of holds shown

Signed-off-by: David Cook <dcook@prosentient.com.au>

Works as described, although as Magnus mentioned, Locations
still use codes instead of descriptions.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 0f7f6a5cb32cd2e68bc39e8464147852347be310)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 773d7e2d1faa449ea1bd6f28d2422a195388686e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
---
 .../intranet-tmpl/prog/en/modules/circ/pendingreserves.tt | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
index 1cf144e529..62bfd763be 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
@@ -1,4 +1,6 @@
 [% USE KohaDates %]
+[%- USE Branches -%]
+[%- USE ItemTypes -%]
 [% INCLUDE 'doc-head-open.inc' %]
 <title>Koha &rsaquo; Circulation &rsaquo; Holds to pull</title>
 [% INCLUDE 'doc-head-close.inc' %]
@@ -123,14 +125,14 @@ $(document).ready(function() {
             <td>"</td>
             <td>"</td>
         [% END %]
-        <td>[% reserveloo.holdingbranch %]</td>
+        <td>[% Branches.GetName ( reserveloo.holdingbranch ) %]</td>
         <td><p>[% reserveloo.itemcallnumber %]</p></td>
         <td><p>[% reserveloo.copyno %]</p></td>
         <td><p>[% reserveloo.enumchron %]</p></td>
-        <td>[% reserveloo.itype %]</td>
+        <td>[% ItemTypes.GetDescription( reserveloo.itype ) %]</td>
         <td>[% reserveloo.location %]</td>
         <td>
-            <span title="[% reserveloo.reservedate %]">[% reserveloo.reservedate | $KohaDates %] in [% reserveloo.branch %]</span>
+            <span title="[% reserveloo.reservedate %]">[% reserveloo.reservedate | $KohaDates %] in [% Branches.GetName ( reserveloo.branch ) %]</span>
             [% IF ( reserveloo.statusw ) %]<p>Waiting</p>[% END %][% IF ( reserveloo.statusf ) %]<p>Fullfilled</p>[% END %]
         </td>
         </tr>
-- 
2.20.1