From 7ea252ffa010e6dba469e939eab3b1f900dc9637 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Wed, 30 Aug 2023 13:12:31 +0000 Subject: [PATCH] Bug 34609: Add biblio method to Old::Hold Test plan, clean k-t-d: 1) Add a reserve to koha/koha user, mysql run: insert into reserves(borrowernumber, reservedate, branchcode, cancellationdate, timestamp, biblionumber) VALUES (51, '2022-09-23', 'CPL', '2022-09-23', '2022-09-23 15:46:21', 76); 2) Add an old_reserve to koha/koha user, mysql run: insert into old_reserves(borrowernumber, reservedate, branchcode, cancellationdate, timestamp, reserve_id) VALUES (51, '2022-09-23', 'CPL', '2022-09-23', '2022-09-23 15:46:21', 1); 3) Visit holdshistory on either OPAC (requires OPACHoldsHistory sys pref) or STAFF STAFF/cgi-bin/koha/members/holdshistory.pl?borrowernumber=1 OPAC//cgi-bin/koha/opac-holdshistory.pl 4) Notice it blows up with a 500 error 5) Repeat step 3 Signed-off-by: Ray Delahunty Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 7b57163ef32e08179acd76b245b1b4f49aa93875) Signed-off-by: Fridolin Somers --- Koha/Old/Hold.pm | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Koha/Old/Hold.pm b/Koha/Old/Hold.pm index aa164fcd2a..91f2adb39c 100644 --- a/Koha/Old/Hold.pm +++ b/Koha/Old/Hold.pm @@ -34,6 +34,19 @@ This object represents a hold that has been filled or canceled =head2 Class methods +=head3 biblio + +Returns the related Koha::Biblio object for this old hold + +=cut + +sub biblio { + my ($self) = @_; + my $rs = $self->_result->biblionumber; + return unless $rs; + return Koha::Biblio->_new_from_dbic($rs); +} + =head3 anonymize $old_hold->anonymize(); -- 2.39.5