From 80a7d712aad3539990d17e09fa4af822d81ddd29 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Thu, 14 Aug 2008 10:43:06 -0500 Subject: [PATCH] bug 2518: remove useless patron and branch lookups AddIssue does not use the results of the lookup of the patron whose hold request was preempted by the issue. This patch now leaves a no-op in the '$restype eq "Waiting"' test, but I'm not going to refactor the hold cancellation logic now. Signed-off-by: Galen Charlton --- C4/Circulation.pm | 7 ------- 1 file changed, 7 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index ca52e2764b..9e97d47077 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -909,18 +909,11 @@ sub AddIssue { # warn "Waiting"; # The item is on reserve and waiting, but has been # reserved by some other patron. - my ( $resborrower ) = GetMemberDetails( $resbor, 0 ); - my $branches = GetBranches(); - my $branchname = - $branches->{ $res->{'branchcode'} }->{'branchname'}; } elsif ( $restype eq "Reserved" ) { # warn "Reserved"; # The item is reserved by someone else. - my ( $resborrower ) = GetMemberDetails( $resbor, 0 ); - my $branches = GetBranches(); - my $branchname = $branches->{ $res->{'branchcode'} }->{'branchname'}; if ($cancelreserve) { # cancel reserves on this item CancelReserve( 0, $res->{'itemnumber'}, $res->{'borrowernumber'} ); -- 2.39.5