From 8b44fb4d181d845a81b1d79856df4f03ab05968b Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer@bsz-bw.de>
Date: Tue, 16 Jan 2024 16:10:10 +0000
Subject: [PATCH] Bug 30070: EDIFACT and ID are abbreviations

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 Koha/Edifact/File.pm                           |  6 +++---
 .../V1/Acquisitions/Vendor/Edifact/Files.pm    |  4 ++--
 api/v1/swagger/definitions/edifact_file.yaml   | 18 +++++++++---------
 .../swagger/paths/acquisitions_edifiles.yaml   |  6 +++---
 4 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/Koha/Edifact/File.pm b/Koha/Edifact/File.pm
index 66937acc27..9f24b08f0a 100644
--- a/Koha/Edifact/File.pm
+++ b/Koha/Edifact/File.pm
@@ -23,7 +23,7 @@ use base qw(Koha::Object);
 
 =head1 Name
 
-Koha::Edifact::File - Koha::Object class for single edifact file
+Koha::Edifact::File - Koha::Object class for single EDIFACT file
 
 =head2 Class methods
 
@@ -31,7 +31,7 @@ Koha::Edifact::File - Koha::Object class for single edifact file
 
   my $vendor = $edifile->vendor;
 
-Returns the I<Koha::Acquisition::Bookseller> associated with this edifact file
+Returns the I<Koha::Acquisition::Bookseller> associated with this EDIFACT file
 
 =cut
 
@@ -46,7 +46,7 @@ sub vendor {
 
   my $basket = $edifile->basket;
 
-Returns the I<Koha::Acquisition::Basket> associated with this edifact file.
+Returns the I<Koha::Acquisition::Basket> associated with this EDIFACT file.
 
 =cut
 
diff --git a/Koha/REST/V1/Acquisitions/Vendor/Edifact/Files.pm b/Koha/REST/V1/Acquisitions/Vendor/Edifact/Files.pm
index d672038e5d..a3b84606e6 100644
--- a/Koha/REST/V1/Acquisitions/Vendor/Edifact/Files.pm
+++ b/Koha/REST/V1/Acquisitions/Vendor/Edifact/Files.pm
@@ -33,13 +33,13 @@ Koha::REST::V1::Acquisitions::Edifact::Files
 
 =head3 list
 
-Controller function that handles edifact files
+Controller function that handles EDIFACT files
 
 =cut
 
 =head3 list
 
-Return the list of edifact files
+Return the list of EDIFACT files
 
 =cut
 
diff --git a/api/v1/swagger/definitions/edifact_file.yaml b/api/v1/swagger/definitions/edifact_file.yaml
index 2f7699de80..4602ba28b6 100644
--- a/api/v1/swagger/definitions/edifact_file.yaml
+++ b/api/v1/swagger/definitions/edifact_file.yaml
@@ -3,23 +3,23 @@ type: object
 properties:
   id:
     type: integer
-    description: internally assigned edifect file identifier
+    description: internally assigned EDIFACT file identifier
     readOnly: true
   type:
     type:
       - string
-    description: Edifact file type
+    description: EDIFACT file type
   transfer_date:
     type:
       - string
       - "null"
     format: date
-    description: Edifact file transfer date
+    description: EDIFACT file transfer date
   vendor_id:
     type:
       - string
       - "null"
-    description: Koha vendor id
+    description: Koha vendor ID
   vendor:
     type:
       - object
@@ -29,17 +29,17 @@ properties:
     type:
       - string
       - "null"
-    description: Edifact account
+    description: EDIFACT account
   status:
     type:
       - string
       - "null"
-    description: Edifact file status
+    description: EDIFACT file status
   basket_id:
     type:
       - string
       - "null"
-    description: Koha basket id
+    description: Koha basket ID
   basket:
     type:
       - object
@@ -49,10 +49,10 @@ properties:
     type:
       - string
       - "null"
-    description: Edifact message
+    description: EDIFACT message
   filename:
     type:
       - string
       - "null"
-    description: Edifact file name
+    description: EDIFACT file name
 additionalProperties: false
diff --git a/api/v1/swagger/paths/acquisitions_edifiles.yaml b/api/v1/swagger/paths/acquisitions_edifiles.yaml
index c7968fcde3..c6ec7d4f24 100644
--- a/api/v1/swagger/paths/acquisitions_edifiles.yaml
+++ b/api/v1/swagger/paths/acquisitions_edifiles.yaml
@@ -5,7 +5,7 @@
     operationId: listEdifactFiles
     tags:
       - edifiles
-    summary: List edifact files
+    summary: List EDIFACT files
     produces:
       - application/json
     parameters:
@@ -30,7 +30,7 @@
 
     responses:
       "200":
-        description: A list of edifact files
+        description: A list of EDIFACT files
         schema:
           type: array
           items:
@@ -44,7 +44,7 @@
         schema:
           $ref: "../swagger.yaml#/definitions/error"
       "404":
-        description: Edifile not found
+        description: EDIFACT file not found
         schema:
           $ref: "../swagger.yaml#/definitions/error"
       "500":
-- 
2.39.2