From 987874f4d866aa89e1cc34062f4bd2b001c52b46 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 4 Mar 2016 08:27:43 -0500 Subject: [PATCH] Bug 15978: Use Font Awesome icons for guided reports error dialog If you try to save an SQL report with an invalid authorized value placeholder you will be presented with a confirmation dialog. This patch updates it to use Font Awesome icons. Also fixed: Validation error found in testing: Duplicated
tag and series of redundant inputs. Each input cut had an exact duplicate in the same form. To test, apply the patch and go to Reports -> Create from SQL. - Create a new SQL report and fill in as many fields as possible to verify correct operation. - Try to save your report with an invalid authorized value placeholder, for example: SELECT * FROM items WHERE items.itype = <> - Confirm that the confirmation dialog is styled correctly. - Test the operation of the "Edit SQL" button. You should be sent back a page. - Test the operation of the "Save anyway" button and confirm that your report was saved. - Repeat these steps when editing an existing report. Signed-off-by: Hector Castro Works as described Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com --- .../modules/reports/guided_reports_start.tt | 80 ++++++++----------- 1 file changed, 33 insertions(+), 47 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index 1655d92685..d766381977 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -702,54 +702,40 @@ canned reports and writing custom SQL reports.

[% END %] [% IF ( warn_authval_problem ) %] - +
+

Errors found when processing parameters for report: [% name %]

+ [% FOREACH problematic_authval IN problematic_authvals %] +

+ [% problematic_authval.name %]: The authorized value category ([% problematic_authval.authval %]) + you selected does not exist. +

+ [% END %] + + - - - - - - - - - - -
-

Errors found when processing parameters for report: [% name %]

- [% FOREACH problematic_authval IN problematic_authvals %] -

- [% problematic_authval.name %]: The authorized value category ([% problematic_authval.authval %]) - you selected does not exist. -

- [% END %] - - - - - - - - - - - - - [% IF ( phase_update) %] - - - [% ELSIF ( phase_save) %] - - - - [% END %] - - -
- -
-
- + + + + + + + + + + [% IF ( phase_update) %] + + + [% ELSIF ( phase_save) %] + + + + [% END %] + + +
+ +
+
[% END %] [% IF ( enter_params ) %] -- 2.39.5