From a1dcd2f2e67f2dc998d2eae0fc6097eb9edbb874 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 3 Oct 2016 15:23:39 +0100 Subject: [PATCH] Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Signed-off-by: Hector Castro Warnings avoided Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher --- C4/ImportExportFramework.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/C4/ImportExportFramework.pm b/C4/ImportExportFramework.pm index 2d3bf07bf4..bc02cca203 100644 --- a/C4/ImportExportFramework.pm +++ b/C4/ImportExportFramework.pm @@ -278,9 +278,10 @@ sub _export_table_csv $sth->execute($frameworkcode); my $data; while (my $hashRef = $sth->fetchrow_hashref) { - for (@fields) { - $hashRef->{$_} =~ s/[\r\n]//g; - $$strCSV .= '"' . $hashRef->{$_} . '",'; + for my $field (@fields) { + my $value = $hashRef->{$field} // q||; + $value =~ s/[\r\n]//g; + $$strCSV .= '"' . $value . '",'; } chop $$strCSV; $$strCSV .= chr(10); -- 2.39.5