From a6bf70a9fcf8ab91acd36ecc46d5f62c629b3766 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 14 Jan 2021 17:53:49 +0000 Subject: [PATCH] Bug 27439: Improve hint labels on patron attribute type entry form This patch makes some minor changes to the patron attribute type template in order make corrections and improve consistency: - Change some generic s to
- Correct terminology: Branch -> Library - Improve hint text: Before: "Select All if this attribute type must to be displayed all the time." After: "Select "All libraries" if this attribute type should always be displayed" - Link reference to authorized values "PA_CLASS" directly to that page for users with permission. To test, apply the patch and go to Administration -> Patron attribute types -> New patron attribute type. - Confirm that the hints on these fields are properly styled: Authorized value category, Library limitation, Category, and Class. - Confirm that the text uses the term "library" instead of "branch." - Confirm that the hint on the "Class" field links directly to authorized values if you are logged in with a user with permission. Signed-off-by: Victoria Faafia Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- .../en/modules/admin/patron-attr-types.tt | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt index 227daf7137..638d8a5894 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt @@ -161,17 +161,15 @@ [% PROCESS options_for_authorised_value_categories authorised_value_categories => AuthorisedValues.GetCategories( selected => attribute_type.authorised_value_category ) %] - Authorized value category; if one is selected, the patron record input page will only allow values - to be chosen from the authorized value list. However, an authorized value list is not - enforced during batch patron import. +
Authorized value category; if one is selected, the patron record input page will only allow values to be chosen from the authorized value list. However, an authorized value list is not enforced during batch patron import.
-
  • +
  • - Select All if this attribute type must to be displayed all the time. Otherwise select libraries you want to associate with this value. - +
    Select "All libraries" if this attribute type should always be displayed. Otherwise select libraries you want to associate with this value. +
  • @@ -181,12 +179,18 @@ [% IF ( cat.categorycode == attribute_type.category_code ) %][% ELSE %][% END %] [% END %] - Choose one to limit this attribute to one patron type. Please leave blank if you want these attributes to be available for all types of patrons. +
    Choose one to limit this attribute to one patron type. Please leave blank if you want these attributes to be available for all types of patrons.
  • [% PROCESS 'av-build-dropbox.inc' name="class", category="PA_CLASS" default=attribute_type.class %] - Group attributes types with a block title (based on authorized values category 'PA_CLASS') +
    + [% IF ( CAN_user_parameters_manage_auth_values ) %] + Group attributes types with a block title (based on authorized values category 'PA_CLASS') + [% ELSE %] + Group attributes types with a block title (based on authorized values category 'PA_CLASS') + [% END %] +
  • -- 2.39.5