From a6d77fb4286c3be6fe513a95bc258b7b3fb45c03 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Tue, 16 Mar 2021 16:39:13 +0000 Subject: [PATCH] Bug 27967: Add min attribute to borraccount modals This patch adds a min attribute to the form fields of the borrower account page modals to prevent negative values being entered inappropriately. Test plan 1/ Trigger the refund modal from the borrower account page. 2/ Attempt to enter a negative value for the amount to refund and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 3/ Trigger the discount modal from the borrower account page. 4/ Attempt to enter a negative value for the amount to discount and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 5/ Signoff Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt index b23267b970..f2be33ab51 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt @@ -382,7 +382,7 @@ var amountoutstanding = button.data('amountoutstanding'); var paid = amount - amountoutstanding; $("#paid + span").replaceWith(paid); - $("#returned").attr({ "value": paid, "max": paid }); + $("#returned").attr({ "value": paid, "max": paid, "min": 0 }); $("#returned, #refund_transaction_type").focus(); }); @@ -394,7 +394,7 @@ $('#discountline').val(accountline); var amount = button.data('amount'); $("#charged + span").replaceWith(amount); - $("#discount").attr({ "max": amount }); + $("#discount").attr({ "max": amount, "min": 0 }); $("#discount").focus(); }); }); -- 2.39.5