From a84935b83ea6013d96cfdc3c15291d47a3b00fa9 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Mon, 29 Dec 2008 19:42:45 -0600 Subject: [PATCH] bug 2505: further warnings fixes to memberentry.pl Signed-off-by: Galen Charlton --- members/memberentry.pl | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/members/memberentry.pl b/members/memberentry.pl index 5609d84bd6..26c05bb649 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -19,7 +19,7 @@ # pragma use strict; -use warnings; # FIXME: really. +use warnings; # external modules use CGI; @@ -119,8 +119,10 @@ my %newdata; # comes from $input->param() if ($op eq 'insert' || $op eq 'modify' || $op eq 'save') { my @names= ($borrower_data && $op ne 'save') ? keys %$borrower_data : $input->param(); foreach my $key (@names) { - $newdata{$key} = $input->param($key) if (defined $input->param($key)); - $newdata{$key} =~ s/\"/"/gg unless $key eq 'borrowernotes' or $key eq 'opacnote'; + if (defined $input->param($key)) { + $newdata{$key} = $input->param($key); + $newdata{$key} =~ s/\"/"/g unless $key eq 'borrowernotes' or $key eq 'opacnote'; + } } my $dateobject = C4::Dates->new(); my $syspref = $dateobject->regexp(); # same syspref format for all 3 dates @@ -380,7 +382,7 @@ foreach (qw(C A S P I X)) { $template->param('typeloop' => \@typeloop); # test in city -$select_city=getidcity($data{'city'}) if ($guarantorid ne '0'); +$select_city=getidcity($data{'city'}) if defined $guarantorid and ($guarantorid ne '0'); ($default_city=$select_city) if ($step eq 0); if (!defined($select_city) or $select_city eq '' ){ $default_city = &getidcity($data{'city'}); -- 2.20.1