From adedefb512909a4760cd49d53cdaca648e6f2aa1 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Sun, 8 Feb 2015 21:57:26 +0100 Subject: [PATCH] Bug 13648: OPAC = hidden removes pull down from edit item form If you uncheck the checkbox OPAC in the bibliographic framework definition for an item subfield that is linked to an authorized value list, the pull down will disappear from the item edit form on staff. The label still shows. 1) Go to administration > bibliographic frameworks 2) Select a framework and go to the item field (MARC21: 952) 3) Edit a subfield with an authorized values list like damaged, lost or withdrawn 4) Uncheck the checkbox for OPAC visibility 5) Edit or add an item within your chosen framework 6) Verify the subfield code and description are shown, but the pull down has disappeared 7) Apply patch, verify the pull down shows now 8) Also test following hidden combination works correctly: OPAC: checked All other options: unchecked Documentation of hidden values: http://wiki.koha-community.org/wiki/Hidden_values With special thanks to Jonathan Druart for helping me figure this out! Signed-off-by: Nicole C. Engard Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit fbf73f43184841c74aff3998c0b80a0f44d97466) Signed-off-by: Chris Cormack --- cataloguing/additem.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl index efde341701..ac57797885 100755 --- a/cataloguing/additem.pl +++ b/cataloguing/additem.pl @@ -136,7 +136,7 @@ sub generate_subfield_form { $value =~ s/DD/$day/g; } - $subfield_data{visibility} = "display:none;" if (($subfieldlib->{hidden} > 4) || ($subfieldlib->{hidden} < -4)); + $subfield_data{visibility} = "display:none;" if (($subfieldlib->{hidden} > 4) || ($subfieldlib->{hidden} <= -4)); my $pref_itemcallnumber = C4::Context->preference('itemcallnumber'); if (!$value && $subfieldlib->{kohafield} eq 'items.itemcallnumber' && $pref_itemcallnumber) { @@ -231,7 +231,7 @@ sub generate_subfield_form { } } - if ($subfieldlib->{'hidden'}) { + if ( $subfieldlib->{hidden} > 4 or $subfieldlib->{hidden} <= -4 ) { $subfield_data{marc_value} = qq( $authorised_lib{$value}); } else { -- 2.39.5