From b2a8e726fe32d4aae3f279f4142af240c60d7fe5 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 19 Jul 2017 14:57:26 -0400 Subject: [PATCH] Bug 13012 - suggestion.suggesteddate should be set to NOW if not defined MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Suggestions.t Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart --- Koha/Suggestion.pm | 18 ++++++++++++++++++ t/db_dependent/Koha/Suggestions.t | 5 ++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/Koha/Suggestion.pm b/Koha/Suggestion.pm index a091f43f2a..2fef425197 100644 --- a/Koha/Suggestion.pm +++ b/Koha/Suggestion.pm @@ -22,6 +22,7 @@ use Modern::Perl; use Carp; use Koha::Database; +use Koha::DateUtils qw(dt_from_string); use base qw(Koha::Object); @@ -35,6 +36,23 @@ Koha::Suggestion - Koha Suggestion object class =cut +=head3 store + +Override the default store behavior so that new suggestions have +a suggesteddate of today + +=cut + +sub store { + my ($self) = @_; + + unless ( $self->suggesteddate() ) { + $self->suggesteddate( dt_from_string()->ymd ); + } + + return $self->SUPER::store(); +} + =head3 type =cut diff --git a/t/db_dependent/Koha/Suggestions.t b/t/db_dependent/Koha/Suggestions.t index e29f2af558..0a2af42345 100644 --- a/t/db_dependent/Koha/Suggestions.t +++ b/t/db_dependent/Koha/Suggestions.t @@ -19,11 +19,12 @@ use Modern::Perl; -use Test::More tests => 4; +use Test::More tests => 5; use Koha::Suggestion; use Koha::Suggestions; use Koha::Database; +use Koha::DateUtils; use t::lib::TestBuilder; @@ -46,6 +47,8 @@ my $new_suggestion_2 = Koha::Suggestion->new( } )->store; +is( $new_suggestion_1->suggesteddate, dt_from_string()->ymd, "If suggesteddate not passed in, it will default to today" ); + like( $new_suggestion_1->suggestionid, qr|^\d+$|, 'Adding a new suggestion should have set the suggestionid' ); is( Koha::Suggestions->search->count, $nb_of_suggestions + 2, 'The 2 suggestions should have been added' ); -- 2.39.5