From b6ace414f72be24949acb07f1c739bb031cc1faf Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 8 Aug 2022 12:15:16 +0000 Subject: [PATCH] Bug 25375: Match current Zebra availability limit MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In Zebra the availability limit code states: 'available' is defined as (items.onloan is NULL) and (items.itemlost = 0) We should make ES follow the same behaviour so that changing the engine does not change this. To test: 1 - Find or create several records with two items each 2 - For those records setup items as: a - one checked out, one available b - both marked lost c - both damaged d - both withdrawn e - both notforloan 3 - Enable ES and reindex to confirm everything is set 4 - Perform an advanced search to return those records and 'limit to available items' 5 - Confirm you see records b,c,d,e and records say '2 items, none available' 6 - Apply patch 7 - Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 8 - Perform an advanced search to return those records and 'limit to available items' 9 - Confirm you see records a,b,c,d and al but a say '2 items, none available' Signed-off-by: Joonas Kylmälä Signed-off-by: Tomas Cohen Arazi --- Koha/SearchEngine/Elasticsearch.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm index b2273c5ace..28dd05c2f3 100644 --- a/Koha/SearchEngine/Elasticsearch.pm +++ b/Koha/SearchEngine/Elasticsearch.pm @@ -782,9 +782,6 @@ sub marc_records_to_documents { biblionumber => $biblionumber, onloan => undef, notforloan => 0, - withdrawn => 0, - itemlost => 0, - damaged => 0 })->count; $record_document->{available} = $avail_items ? \1 : \0; -- 2.39.5