From c09df7ab9d6b0b75281af637b54ec9d3096334d5 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 26 Nov 2014 13:51:45 +1300 Subject: [PATCH] Bug 13331 Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks to test... 1/ attempt to add a new bib in the cataloguing editor, default framewok - observe 245b subfield is visible in the editor, for tab 2 2/ uncheck the OPAC visibility for 245b, within the framework editor - then save 3/ repeat step 1/ - observe that the 245b subfield has disappeared from the cataloguing editor! 4/ apply patch, 5/ repeat step 1/ - observe that the 245b subfield now displays correctly in the cataloguing editor note: this looks looks like a typo bug, that has been in koha for years Signed-off-by: wajasu Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a42954627ec129e47ebc47d36cf87d33617bd808) Signed-off-by: Chris Cormack --- cataloguing/addbiblio.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl index 5b06706863..645a30a214 100755 --- a/cataloguing/addbiblio.pl +++ b/cataloguing/addbiblio.pl @@ -653,8 +653,8 @@ sub build_tabs { foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) { next if ( length $subfield != 1 ); next - if ( ( $tagslib->{$tag}->{$subfield}->{hidden} <= -5 ) - or ( $tagslib->{$tag}->{$subfield}->{hidden} >= 4 ) ) + if ( ( $tagslib->{$tag}->{$subfield}->{hidden} <= -4 ) + or ( $tagslib->{$tag}->{$subfield}->{hidden} >= 5 ) ) and not ( $subfield eq "9" and exists($tagslib->{$tag}->{'a'}->{authtypecode}) and defined($tagslib->{$tag}->{'a'}->{authtypecode}) and -- 2.20.1