From c123b414800a9a7f20d1a7948baa6ea43025eec6 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer@bsz-bw.de>
Date: Fri, 17 Mar 2023 17:43:18 +0000
Subject: [PATCH] Bug 19361: (QA follow-up) Make sure "Not an authorised value"
 appears in the pull down

This is to make sure that the small icon with the additional tooltip
style explanation is not as easily missed.

Also updates text slightly:
* Pull downs: "X (Not an authorised value)"
* Tooltip: "The current value X is not configured for the authorised value category controlling this subfield"

Switches from exclamation triangle to the more "alerting" exclamation-triangle :)

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc   | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc   | 4 ++--
 .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt  | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
index 7fc306aa64..a167314729 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
@@ -122,7 +122,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr
                             $node.append( '<option value="' + authval.value + '"' + selected + '>' + authval.lib + '</option>' );
                         } );
                         if( !matched ){
-                            $node.append( "<option value='" + value + "' selected='selected'>" + value + " " + _("(Not in authorised values list)") + " " + "</option>" );
+                            $node.append( "<option value='" + value + "' selected='selected'>" + value + " " + _("(Not an authorised value)") + " " + "</option>" );
                         }
                         $node.val( this.text );
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
index 8353980000..e2230dd631 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
@@ -126,9 +126,9 @@
                         [% END %]
                         [% UNLESS matched || ( ( kohafield == 'items.damaged' || kohafield == 'items.itemlost' || kohafield == 'items.withdrawn' || kohafield == 'items.notforloan' ) && mv.default == '0' ) %]
                         [%# If the current value is not in the authorised list  and is not a field where 0 means unset #%]
-                                <option value="[%- mv.default | html -%]" selected="selected">[%- mv.default | html -%]</option>
+                                <option value="[%- mv.default | html -%]" selected="selected">[%- mv.default | html -%] (Not an authorised value)</option>
                             </select>
-                            <span style="float:right;" title="The current value [% mv.default | html %] is not in the authorised value list"><i class="fa fa-exclamation-circle" aria-hidden="true"></i></span>
+                            <span style="float:right;" title="The current value [% mv.default | html %] is not configured for the authorised value category controlling this subfield"><i class="fa fa-exclamation-triangle" aria-hidden="true"></i></span>
                         [% ELSE %]
                             </select>
                         [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
index d27ee41700..0207a5e9e1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
@@ -1159,10 +1159,10 @@ function PopupMARCFieldDoc(field) {
                                                                 [% END %]
 
                                                             [% END %]
-                                                            [% UNLESS matched # If the current value is not in the authorised list %]
-                                                                <option value="[%- mv.default | html -%]" selected="selected">[%- mv.default | html -%]</option>
+                                                            [% UNLESS matched # If the current value is not in the authorised value list %]
+                                                                <option value="[%- mv.default | html -%]" selected="selected">[%- mv.default | html -%] (Not an authorised value)</option>
                                                             </select>
-                                                            <span style="float:right;" title="The current value [% mv.default | html %] is not in the authorised value list"><i class="fa fa-exclamation-circle" aria-hidden="true"></i></span>
+                                                            <span style="float:right;" title="The current value [% mv.default | html %] is not configured for the authorised value category controlling this subfield"><i class="fa fa-exclamation-triangle" aria-hidden="true"></i></span>
                                                             [% ELSE %]
                                                             </select>
                                                             [% END %]
-- 
2.20.1