From c191532cc0c908ccbd5019a0d49c721e5702e7a6 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Wed, 28 Aug 2013 14:44:01 +0000 Subject: [PATCH] Bug 10767: (follow-up) remove FIXME comments The FIXME comments in the new test script were based on an assumption that GetIssuingRules() should return multiple rules if no or only partial parameters are passed. This is not the intent of that routine, whose purpose is to return the *singular* rule that best applies to a given loan situation. In other words, GetIssuingRule() is not a traditional accessor function. Signed-off-by: Galen Charlton --- t/db_dependent/Circulation_Issuingrule.t | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/t/db_dependent/Circulation_Issuingrule.t b/t/db_dependent/Circulation_Issuingrule.t index a9f9fb5cfb..fc567a8ce4 100644 --- a/t/db_dependent/Circulation_Issuingrule.t +++ b/t/db_dependent/Circulation_Issuingrule.t @@ -279,15 +279,6 @@ is_deeply( "GetIssuingCharge returns issuingrule1's informations" ); -#FIX ME: Currently, GetIssuingRule without parameters returns an issuingrule with branchcode -> *,categorycode -> *, itemtype -> * -#is_deeply ( GetIssuingRule(),{$sampleissuingrule1,$sampleissuingrule2,$sampleissuingrule3},"Without parameters, GetIssuingRule returns all the issuingrule"); - -#FIX ME: Currently, GetIssuingRule with only one parameter returns an issuingrule with branchcode -> *,categorycode -> *, itemtype -> * -#is_deeply(GetIssuingRule($samplecat->{categorycode}),{$sampleissuingrule1,$sampleissuingrule2,$sampleissuingrule3},"GetIssuingRule with a categorycode returns all the issuingrules of this category"); - -#FIX ME: Currently, GetIssuingRule with only two parameters returns an issuingrule with branchcode -> *,categorycode -> *, itemtype -> * -#is_deeply(GetIssuingRule($samplecat->{categorycode},'BOOK'),{$sampleissuingrule1,$sampleissuingrule2},"GetIssuingRule with a categorycode and'Book' returns all the issuingrules of this category and the itemtype = book"); - #Test GetLoanLength is_deeply( C4::Circulation::GetLoanLength( @@ -346,12 +337,5 @@ is_deeply( "GetHardDueDate returns the duedate and the duedatecompare" ); -#FIXME: Currently, with wrong parameters GetHardDueDate returns '' because GetIssuingrule returns wrong value -#@hardduedate = C4::Circulation::GetHardDueDate(-1,-1,-1); -#is_deeply(\@hardduedate,[undef,undef],"GetHardDueDate with wrong parameters returns undef"); -#FIXME: Currently, without parameter GetHardDueDate returns '' because GetIssuingrule returns wrong value -#@hardduedate = C4::Circulation::GetHardDueDate(); -#is_deeply(\@hardduedate,[undef,undef],"GetHardDueDate without parameter returns undef"); - #End transaction $dbh->rollback; -- 2.39.5