From c1af56eb54043909f7e32b4597baa4f2d4d3e7dd Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Wed, 27 Feb 2019 06:59:08 -0500
Subject: [PATCH] Bug 14708: The patron set as the anonymous patron should not
 be deletable.

Right now it's possible to delete the anonymous patron at any time. When this happens the system will break just as if anonymouspatron was unset but patrons still have an "always anonymize" privacy setting.

This issue occurs more frequently than one would expect.

We should make it so that the patron set in AnonymousPatron is not deletable.

Test Plan:
1) Apply this patch
2) Set a patron to by AnonymousPatron
3) Attempt to delete that patron from the members toolbar
4) Note the error message!

Signed-off-by: Devinim <kohadevinim@devinim.com.tr>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../intranet-tmpl/prog/en/modules/members/moremember.tt    | 4 ++++
 members/deletemem.pl                                       | 7 +++++++
 2 files changed, 11 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
index a4620be757..85fc32f61a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ -51,6 +51,10 @@
                                 <h3>Unable to delete patrons from other libraries with current settings</h3>
                                 <p>Insufficient privileges.</p>
                             [% END %]
+                            [% IF ( error == 'CANT_DELETE_ANONYMOUS_PATRON' ) %]
+                                <h3>Unable to delete patron that is set as AnonymousPatron</h3>
+                                <p>This patron cannot be deleted while set as AnonymousPatron in the system preferences.</p>
+                            [% END %]
                             [% IF ( error == 'CANT_DELETE' ) %]
                                 <h3>Unable to delete patron</h3>
                                 <p>Insufficient privileges.</p>
diff --git a/members/deletemem.pl b/members/deletemem.pl
index 8980344df1..a01dd39a87 100755
--- a/members/deletemem.pl
+++ b/members/deletemem.pl
@@ -83,6 +83,13 @@ if (C4::Context->preference("IndependentBranches")) {
     }
 }
 
+if ( my $anonymous_patron = C4::Context->preference("AnonymousPatron") ) {
+    if ( $patron->id eq $anonymous_patron ) {
+        print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_ANONYMOUS_PATRON");
+        exit 0;    # Exit without error
+    }
+}
+
 my $op = $input->param('op') || 'delete_confirm';
 my $dbh = C4::Context->dbh;
 my $is_guarantor = $patron->guarantee_relationships->count;
-- 
2.20.1