From ccb86ed6ff58e58c9e7793b03417fab50c26a72b Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 29 May 2023 07:12:57 +0000 Subject: [PATCH] Bug 33869: Matcher.t - indentation and whitespace changes Test plan: Run git diff --ignore-all-space --ignore-blank-lines HEAD~1.. t/Matcher.t; #no output expected Signed-off-by: Marcel de Rooy Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- t/Matcher.t | 45 ++++++++++++++++----------------------------- 1 file changed, 16 insertions(+), 29 deletions(-) diff --git a/t/Matcher.t b/t/Matcher.t index bc5ccb7659..cda2dcbea4 100755 --- a/t/Matcher.t +++ b/t/Matcher.t @@ -41,41 +41,31 @@ subtest 'GetMatcherList' => sub { value => { code => 'ISSN', description => 'ISSN', record_type => 'blue', threshold => 0 }, }); -my @matchers = C4::Matcher::GetMatcherList(); + my @matchers = C4::Matcher::GetMatcherList(); + is( $matchers[0]->{'matcher_id'}, $matcher1->{matcher_id}, 'First matcher_id value' ); + is( $matchers[1]->{'matcher_id'}, $matcher2->{matcher_id}, 'Second matcher_id value' ); -is( $matchers[0]->{'matcher_id'}, $matcher1->{matcher_id}, 'First matcher_id value' ); + my $matcher_id = C4::Matcher::GetMatcherId('ISBN'); + is( $matcher_id, $matcher1->{matcher_id}, 'testing getmatcherid' ); -is( $matchers[1]->{'matcher_id'}, $matcher2->{matcher_id}, 'Second matcher_id value' ); + my $testmatcher; + ok( $testmatcher = C4::Matcher->new( 'red', 1 ), 'testing matcher new' ); + ok( $testmatcher = C4::Matcher->new( 'blue', 0 ), 'testing matcher new' ); -my $matcher_id = C4::Matcher::GetMatcherId('ISBN'); + $testmatcher->threshold(1000); + is( $testmatcher->threshold(), 1000, 'testing threshhold accessor method' ); -is( $matcher_id, $matcher1->{matcher_id}, 'testing getmatcherid' ); + $testmatcher->_id(53); + is( $testmatcher->_id(), 53, 'testing _id accessor' ); -my $testmatcher; + $testmatcher->code('match on ISBN'); + is( $testmatcher->code(), 'match on ISBN', 'testing code accessor' ); -ok( $testmatcher = C4::Matcher->new( 'red', 1 ), 'testing matcher new' ); - -ok( $testmatcher = C4::Matcher->new( 'blue', 0 ), 'testing matcher new' ); - -$testmatcher->threshold(1000); - -is( $testmatcher->threshold(), 1000, 'testing threshhold accessor method' ); - -$testmatcher->_id(53); - -is( $testmatcher->_id(), 53, 'testing _id accessor' ); - -$testmatcher->code('match on ISBN'); - -is( $testmatcher->code(), 'match on ISBN', 'testing code accessor' ); - -$testmatcher->description('match on ISSN'); - -is( $testmatcher->description(), 'match on ISSN', 'testing code accessor' ); + $testmatcher->description('match on ISSN'); + is( $testmatcher->description(), 'match on ISSN', 'testing code accessor' ); }; subtest '_get_match_keys() tests' => sub { - plan tests => 21; my $matchpoint = get_title_matchpoint({ @@ -283,7 +273,6 @@ subtest '_get_match_keys() leader tests' => sub { }; sub get_title_matchpoint { - my $params = shift; my $length = $params->{length} // 0; @@ -312,7 +301,6 @@ sub get_title_matchpoint { } sub get_authors_matchpoint { - my $params = shift; my $length = $params->{length} // 0; @@ -350,7 +338,6 @@ sub get_authors_matchpoint { } sub get_isbn_matchpoint { - my $params = shift; my $length = $params->{length} // 0; -- 2.39.5