From cd762ddcd2a0518273cdbd706a3831f8b5634532 Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Tue, 29 Mar 2022 05:37:30 +1300 Subject: [PATCH] Bug 30402: Import authorities subroutines to ImportBatch script The following authorities subroutines are used by the ImportBatch script but are not accessible, because they aren't imported. This caused MARC importing errors. - GetAuthorityXML - ModAuthority - DelAuthority These affected the BatchCommitRecords and BatchRevertRecords routines, and it wasn't caught because there are no tests written for them. To test: 1. Find an existing authority record, or import one to use. 2. Save this authority record (export/download). 3. Go to Admin -> Record matching rules. Create a new record matching rule for authorities that matches on 001, Local-Number index. 4. Go to Tools -> Stage MARC for import. Upload the authority file you just downloaded. 5. Change record type to authority. 6. Under 'Look for existing items in catalog?', set the record matching rule to the rule you just made which matches on 001. If matching record found, replace the existing one. If no match is found, ignore. 7. Stage the record. Once complete, a match should've been found. 8. Go to Staged MARC management. 9. Import the batch into the catalog. Notice it hangs and never completes. 10. Apply the patch and restart services. 11. Repeat steps 4-9. This time importing should be successful. Sponsored-by: Educational Services Australia SCIS Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Fridolin Somers --- C4/ImportBatch.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm index bf060758b1..2692263fe8 100644 --- a/C4/ImportBatch.pm +++ b/C4/ImportBatch.pm @@ -32,7 +32,7 @@ use C4::Biblio qw( ); use C4::Items qw( AddItemFromMarc ModItemFromMarc ); use C4::Charset qw( MarcToUTF8Record SetUTF8Flag StripNonXmlChars ); -use C4::AuthoritiesMarc qw( AddAuthority GuessAuthTypeCode ); +use C4::AuthoritiesMarc qw( AddAuthority GuessAuthTypeCode GetAuthorityXML ModAuthority DelAuthority ); use C4::MarcModificationTemplates qw( ModifyRecordWithTemplate ); use Koha::Items; use Koha::Plugins::Handler; -- 2.39.5