From dfb8982ca79595297c7430243ad90b77e21d8a67 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 9 Mar 2016 10:27:03 -0500 Subject: [PATCH] Bug 16025 [Revised] Use Font Awesome icons on item types localization page MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The item types localization page uses a Glyphicon. This patch converts it to a Font Awesome icon. Also changed in this patch: "Delete" text has been added to the delete link, and a dummy "href" attribute has been added to the link so that it triggers the right kind of cursor. The deletion confirmation JavaScript has been edited to ignore the default click action. To test, apply the patch and go to Administration -> Item types. - Edit any existing item type and click the "Translate into other languages" link. - If there is not an existing translation, add one. Close the modal window and click the "Translate into other languages" link again to redisplay it. - Confirm that there is a "Delete" link next to your translation which is styled correctly. - Confirm that the behavior of the "Delete" link is correct both when confirming and when canceling. Revision adds the "actions" class to the table cell with the delete link to prevent a line break between the icon and the text. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com --- .../intranet-tmpl/prog/en/modules/admin/localization.tt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt index d6bbf458f6..7d86d61a0e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt @@ -148,7 +148,8 @@ send_update_request( data, this ); }); - $("a.delete").on('click', function(){ + $("a.delete").on('click', function(e){ + e.preventDefault(); if ( confirm(_("Are you sure you want to delete this translation?")) ) { var td = $(this).parent(); var tr = $(td).parent(); @@ -226,7 +227,7 @@ [% t.code %] [% t.lang %] [% t.translation %] - + Delete [% END %] -- 2.39.5