From e24a294f393defeea12fd0bbfba73839c29d14f0 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Wed, 5 Aug 2020 18:24:08 +0000
Subject: [PATCH] Bug 26153: Remove the use of jquery.checkboxes plugin from
 items lost report

This patch removes the use of the jquery.checkboxes plugin from the
lost items report page and replaces it with custom JS.

To test, apply the patch and go to Reports -> Lost items.

- Run the report with parameters which will return multiple results.
- On the results page Create a CSV export profile if there's none.
- On the results page test the "Select all" and "Clear all"
  links at the top of the results. The controls should work correctly.

Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../intranet-tmpl/prog/en/modules/reports/itemslost.tt   | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
index 9f0ec54f78..5e89226773 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
@@ -183,7 +183,6 @@
     [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %]
     [% INCLUDE 'columns_settings.inc' %]
     [% Asset.js("js/table_filters.js") | $raw %]
-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
     <script>
         $(document).ready(function() {
             var columns_settings = [% TablesSettings.GetColumns( 'reports', 'lostitems', 'lostitems-table', 'json' ) | $raw %];
@@ -233,13 +232,17 @@
 
             $(".SelectAll").on("click",function(e){
                 e.preventDefault();
-                $("#lostitems-table").checkCheckboxes();
+                $("#lostitems-table input:checkbox").each(function(){
+                    $(this).prop("checked", true);
+                });
                 itemSelectionBuildActionLinks();
             });
 
             $(".ClearAll").on("click",function(e){
                 e.preventDefault();
-                $("#lostitems-table").unCheckCheckboxes();
+                $("#lostitems-table input:checkbox").each(function(){
+                    $(this).prop("checked", false);
+                });
                 itemSelectionBuildActionLinks();
             });
         });
-- 
2.39.5