From e34fa5b5119765d65e0c82dc5b6267b087b30b50 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 8 Nov 2021 10:22:09 +0100 Subject: [PATCH] Bug 29387: Stringify exceptions for other background job modules MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- Koha/BackgroundJob/BatchCancelHold.pm | 2 +- Koha/BackgroundJob/BatchDeleteAuthority.pm | 2 +- Koha/BackgroundJob/BatchDeleteBiblio.pm | 2 +- Koha/BackgroundJob/BatchUpdateAuthority.pm | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Koha/BackgroundJob/BatchCancelHold.pm b/Koha/BackgroundJob/BatchCancelHold.pm index cc9ec6ad3c..5216119ac1 100644 --- a/Koha/BackgroundJob/BatchCancelHold.pm +++ b/Koha/BackgroundJob/BatchCancelHold.pm @@ -94,7 +94,7 @@ sub process { biblio_id => defined $biblio ? $biblio->biblionumber : '', hold_id => $hold_id, error => defined $hold - ? ( $@ ? $@ : 0 ) + ? ( $@ ? "$@" : 0 ) : 'hold_not_found', }; } diff --git a/Koha/BackgroundJob/BatchDeleteAuthority.pm b/Koha/BackgroundJob/BatchDeleteAuthority.pm index 18a3202a6e..99833abcd6 100644 --- a/Koha/BackgroundJob/BatchDeleteAuthority.pm +++ b/Koha/BackgroundJob/BatchDeleteAuthority.pm @@ -57,7 +57,7 @@ sub process { type => 'error', code => 'authority_not_deleted', authid => $authid, - error => ($@ ? $@ : 0), + error => "$@", }; $schema->storage->txn_rollback; next; diff --git a/Koha/BackgroundJob/BatchDeleteBiblio.pm b/Koha/BackgroundJob/BatchDeleteBiblio.pm index c1077716af..6931759286 100644 --- a/Koha/BackgroundJob/BatchDeleteBiblio.pm +++ b/Koha/BackgroundJob/BatchDeleteBiblio.pm @@ -101,7 +101,7 @@ sub process { code => 'reserve_not_cancelled', biblionumber => $biblionumber, reserve_id => $hold->reserve_id, - error => $@, + error => "$@", }; $schema->storage->txn_rollback; $job->progress( ++$job_progress )->store; diff --git a/Koha/BackgroundJob/BatchUpdateAuthority.pm b/Koha/BackgroundJob/BatchUpdateAuthority.pm index 5969a1311d..9eacf58a5f 100644 --- a/Koha/BackgroundJob/BatchUpdateAuthority.pm +++ b/Koha/BackgroundJob/BatchUpdateAuthority.pm @@ -90,7 +90,7 @@ sub process { type => 'error', code => 'authority_not_modified', authid => $authid, - error => ($@ ? $@ : 0), + error => ($@ ? "$@" : 0), }; } else { push @messages, { -- 2.39.5