From e41f2c9824a150d293cffd62de3e3c32d8bc809e Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Fri, 21 Feb 2020 09:41:27 -0500
Subject: [PATCH] Bug 24705: Holds placed via SIP will be given first priority

The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1.

Test Plan:
1) Place a hold via SIP for a record with existing holds
2) Note the new hold is top priority
3) Apply this patch
4) Restart SIP
5) Repeat step 1
6) New hold should be last priority

Signed-off-by: Christofer Zorn <Christofer.Zorn@ajaxlibrary.ca>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
---
 C4/SIP/ILS/Transaction/Hold.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/C4/SIP/ILS/Transaction/Hold.pm b/C4/SIP/ILS/Transaction/Hold.pm
index daefee5d41..84cd9616b8 100644
--- a/C4/SIP/ILS/Transaction/Hold.pm
+++ b/C4/SIP/ILS/Transaction/Hold.pm
@@ -66,7 +66,8 @@ sub do_hold {
         return $self;
     }
 
-    AddReserve( $branch, $patron->borrowernumber, $item->biblionumber );
+    my $priority = C4::Reserves::CalculatePriority($item->biblionumber);
+    AddReserve( $branch, $patron->borrowernumber, $item->biblionumber, undef, $priority );
 
     # unfortunately no meaningful return value
     $self->ok(1);
-- 
2.39.5