From e772277a8aa7402f537ddb3c0886fb9dc3ce2d91 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Wed, 18 Oct 2017 13:59:06 +0200 Subject: [PATCH] Bug 19463: (follow-up) Cosmetic changes String::Random version 0.26 (on Jessie) does not yet support the rand_gen parameter (0.27 does, newest is 0.29 on CPAN now). So alt_rand is only used in determining the size on Jessie. That might be enough though. Adding a documention line in this regard. Removing the obsolete max parameter. Note: I timed alt_rand for the creation of a new Bytes::Random::Secure object each time. But each call is about 0.1 milliseconds. So that should be fine. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- t/lib/TestBuilder.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm index d42372e59b..4ec6dba574 100644 --- a/t/lib/TestBuilder.pm +++ b/t/lib/TestBuilder.pm @@ -438,7 +438,8 @@ sub _gen_text { my $regex = $size > 1 ? '[A-Za-z][A-Za-z0-9_]{'.($size-1).'}' : '[A-Za-z]'; - my $random = String::Random->new( max => $size, rand_gen => \&alt_rand ); + my $random = String::Random->new( rand_gen => \&alt_rand ); + # rand_gen is only supported from 0.27 onward return $random->randregex($regex); } -- 2.39.2