From ebe5f51277db84b983963e513f02b2cd473dc196 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 13 Dec 2021 12:16:06 +0000 Subject: [PATCH] Bug 29679: Remove redundant divider element from reports menu The SQL report batch operations dropdown menu has divider list items which add a border between sections (Bibliographic records, item records, etc.). This element is redundant because the sections have "headers" which also add a border. This patch removes them. To test, apply the patch and run an SQL report which will return results that trigger the batch modification menu: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() There should be no double border in the menu. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall --- .../prog/en/modules/reports/guided_reports_start.tt | 6 ------ 1 file changed, 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index 5a0a5b16be..58e3ad309b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -1038,9 +1038,6 @@ [% END %] [% IF header_ro.has_itemnumbers && ( header_ro.cell == 'itemnumber' || header_types.item( header_ro.cell ) == 'itemnumber' ) %] - [% IF ( batch_biblionumbers ) %] - - [% END %]
  • Batch item modification @@ -1050,9 +1047,6 @@
  • [% END %] [% IF header_ro.cell == 'cardnumber' || header_types.item( header_ro.cell ) == 'cardnumber' %] - [% IF ( batch_biblionumbers || batch_itemnumbers ) %] - - [% END %]
  • Batch patron modification -- 2.39.5