From f0e7260a29ec2768b442490921d74b8ee267f15c Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Sat, 23 Dec 2023 16:19:45 +0000 Subject: [PATCH] Bug 35475: Improve concatenated string and fix error in JS file Fixes 2 problems noted in comment#2 and comment#3 on the bug report. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt index b72459c5f7..63282f8f37 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt @@ -90,7 +90,7 @@ for (item of items[0]) { itemsSet.add({ id: item.item_id, - content: _("Item") + " " + item.external_id, + content: _("Item %s").format(item.external_id), }); } diff --git a/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js b/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js index 4f993869ab..3b325f0fc5 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js +++ b/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js @@ -28,6 +28,6 @@ $("#cancelBookingForm").on('submit', function(e) { }); deleting.fail(function(data) { - $('#cancel_booking_result').replaceWith('
'+_("Failure")+'
'); + $('#cancel_booking_result').replaceWith('
'+__("Failure")+'
'); }); }); -- 2.39.5