From f14020780836c5fbc65331b3918b843761481c36 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 18 Dec 2013 08:37:40 -0500 Subject: [PATCH] Bug 11416: fix case where serials item editor was incorrectly hiding fields In serials/serials-edit.pl, if an item field is hidden from the OPAC, it will not display in the editor, even if the field is marked as visible in the staff intranet and editor. However, the field is still displayed correctly in the items editor ( additem.pl ).: Test Plan: 1) Select an item-level field ( e.g. non-public note ) 2) Create a serial using the default framework ( or one of your choice ) 3) For that framework, mark the chosen field as visible from the intranet and editor, but not the opac. 4) Receive an item for this serial, note your field does not display 5) Use the biblio item editor to add an item ( additem.pl ), not the field displayes 6) Apply this patch 7) Repeat step 4, not the field displayes Signed-off-by: Kim Schwant Signed-off-by: Jonathan Druart PrepareItemrecordDisplay is only used for editor (-4 < hidden < 4) Signed-off-by: Galen Charlton --- C4/Items.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/C4/Items.pm b/C4/Items.pm index 12dce8512a..c183644b6c 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -2688,7 +2688,8 @@ sub PrepareItemrecordDisplay { $subfield_data{mandatory} = $tagslib->{$tag}->{$subfield}->{mandatory}; $subfield_data{repeatable} = $tagslib->{$tag}->{$subfield}->{repeatable}; $subfield_data{hidden} = "display:none" - if $tagslib->{$tag}->{$subfield}->{hidden}; + if ( ( $tagslib->{$tag}->{$subfield}->{hidden} > 4 ) + || ( $tagslib->{$tag}->{$subfield}->{hidden} < -4 ) ); my ( $x, $defaultvalue ); if ($itemrecord) { ( $x, $defaultvalue ) = _find_value( $tag, $subfield, $itemrecord ); -- 2.39.2