From f5ac9b281ef259dfd837178c519a8a83effcb20d Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 1 Dec 2022 09:52:55 +1100 Subject: [PATCH] Bug 32302: Hide "ISBN" label when no ISBN data when sending list There is a logic mistake in the opac-sendshelf.tt template where we test if the "ISBN" key exists in the "BIBLIO_RESULT" hash when we should really be testing if the arrayref returned by "ISBN" is empty or not, since that "ISBN" key always exists and contains at least an empty arrayref. Test plan: 1. Apply patch and restart your Koha Starman 2. Create a public list containing records with 020 MARC fields and records without 020 MARC fields 3. View the list in the OPAC 4. Click "Send list" and email it to yourself 5. Note that only records with 020 MARC fields with show "ISBN:" in the email output Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 44366c09858364ac56fd37b5434bc77e7e48fe94) Signed-off-by: Martin Renvoize (cherry picked from commit 45a53a3d5e12ac9fb2ce016a90cd80895763298b) Signed-off-by: Lucas Gass --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt index be952e2399..0d4b2d8b63 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt @@ -56,7 +56,7 @@ Your list : [% shelfname | $raw %]
[% END %] - [% IF ( BIBLIO_RESULT.ISBN ) %] + [% IF ( BIBLIO_RESULT.ISBN.size > 0 ) %] ISBN: [% FOREACH isbn IN BIBLIO_RESULT.ISBN %] [% isbn | $raw %] -- 2.39.5