From f9b3eabab01f301a95e12d9d0ef6d3505902d8bb Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 20 Mar 2015 09:09:45 -0400 Subject: [PATCH] Bug 12820: [QA Followup] Tab and whitespace cleanup Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 836a7eba0b76a034a18fd0bfc46b97caf907dc10) Signed-off-by: Chris Cormack --- C4/SIP/Sip/MsgType.pm | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm index f22648ab7a..bf17158222 100644 --- a/C4/SIP/Sip/MsgType.pm +++ b/C4/SIP/Sip/MsgType.pm @@ -514,19 +514,18 @@ sub handle_checkout { my $fee_ack = $fields->{(FID_FEE_ACK)}; - if ($no_block eq 'Y') { - # Off-line transactions need to be recorded, but there's - # not a lot we can do about it - syslog("LOG_WARNING", "received no-block checkout from terminal '%s'", - $account->{id}); - - $status = $ils->checkout_no_block($patron_id, $item_id, - $sc_renewal_policy, - $trans_date, $nb_due_date); - } else { - # Does the transaction date really matter for items that are - # checkout out while the terminal is online? I'm guessing 'no' - $status = $ils->checkout($patron_id, $item_id, $sc_renewal_policy, $fee_ack); + if ( $no_block eq 'Y' ) { + + # Off-line transactions need to be recorded, but there's + # not a lot we can do about it + syslog( "LOG_WARNING", "received no-block checkout from terminal '%s'", $account->{id} ); + + $status = $ils->checkout_no_block( $patron_id, $item_id, $sc_renewal_policy, $trans_date, $nb_due_date ); + } + else { + # Does the transaction date really matter for items that are + # checkout out while the terminal is online? I'm guessing 'no' + $status = $ils->checkout( $patron_id, $item_id, $sc_renewal_policy, $fee_ack ); } $item = $status->item; @@ -601,14 +600,15 @@ sub handle_checkout { } } } - if ($protocol_version >= 2) { - # Financials : return irrespective of ok status - if ($status->fee_amount) { - $resp .= add_field(FID_FEE_AMT, $status->fee_amount); - $resp .= maybe_add(FID_CURRENCY, $status->sip_currency); - $resp .= maybe_add(FID_FEE_TYPE, $status->sip_fee_type); - $resp .= maybe_add(FID_TRANSACTION_ID, - $status->transaction_id); + + if ( $protocol_version >= 2 ) { + + # Financials : return irrespective of ok status + if ( $status->fee_amount ) { + $resp .= add_field( FID_FEE_AMT, $status->fee_amount ); + $resp .= maybe_add( FID_CURRENCY, $status->sip_currency ); + $resp .= maybe_add( FID_FEE_TYPE, $status->sip_fee_type ); + $resp .= maybe_add( FID_TRANSACTION_ID, $status->transaction_id ); } } -- 2.39.5