From f9c8822766b380b00425882dafa29f17a320d82c Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Thu, 22 Mar 2012 11:03:19 +0100
Subject: [PATCH] Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio
 script corrected

Patch resolves incorrect call to GetShelf in opac and staff. It was and is harmless, because the singlecategory variable was not really used (the category$x param was ignored in the template). Just a cleanup operation.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
---
 opac/opac-addbybiblionumber.pl      | 3 +--
 virtualshelves/addbybiblionumber.pl | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/opac/opac-addbybiblionumber.pl b/opac/opac-addbybiblionumber.pl
index b1a460ee16..6069e76a70 100755
--- a/opac/opac-addbybiblionumber.pl
+++ b/opac/opac-addbybiblionumber.pl
@@ -115,12 +115,11 @@ sub HandleShelfNumber {
 sub HandleSelectedShelf {
     if($authorized= ShelfPossibleAction( $loggedinuser, $selectedshelf, 'add')){
         #adding to specific shelf
-        my ($singleshelf, $singleshelfname, $singlecategory)= GetShelf($query->param('selectedshelf'));
+        my ($singleshelf, $singleshelfname)= GetShelf($query->param('selectedshelf'));
         $template->param(
         singleshelf               => 1,
         shelfnumber               => $singleshelf,
         shelfname                 => $singleshelfname,
-        "category$singlecategory" => 1
         );
     }
 }
diff --git a/virtualshelves/addbybiblionumber.pl b/virtualshelves/addbybiblionumber.pl
index d039e42919..5fd82b3cd0 100755
--- a/virtualshelves/addbybiblionumber.pl
+++ b/virtualshelves/addbybiblionumber.pl
@@ -161,12 +161,11 @@ sub HandleShelfNumber {
 sub HandleSelectedShelf {
     if($authorized= ShelfPossibleAction( $loggedinuser, $shelfnumber, 'add')){
         #confirm adding to specific shelf
-        my ($singleshelf, $singleshelfname, $singlecategory)= GetShelf($shelfnumber);
+        my ($singleshelf, $singleshelfname)= GetShelf($shelfnumber);
         $template->param(
         singleshelf               => 1,
         shelfnumber               => $singleshelf,
         shelfname                 => $singleshelfname,
-        "category$singlecategory" => 1
         );
     }
     else {
-- 
2.39.2