From fad58b08ba76e260a400a87ce86a0941d10af4ad Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 6 Feb 2024 11:26:05 +0100
Subject: [PATCH] Bug 34478: Fix xt/find-missing-csrf.t

It was reporting false positives.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 xt/find-missing-csrf.t | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/xt/find-missing-csrf.t b/xt/find-missing-csrf.t
index 15dd6ae626..02692bcd6f 100755
--- a/xt/find-missing-csrf.t
+++ b/xt/find-missing-csrf.t
@@ -66,16 +66,17 @@ sub check_csrf_in_forms {
     my @errors;
     return @errors unless grep { $_ =~ m|<form| } @lines;
     my ( $open, $found ) = ( 0, 0 );
-    my $line = 0 ;
-    for my $l (@lines) {
-        $line++;
-        $open = $line if ( $l =~ m{<form} && !( $l =~ m{method=('|")get('|")} ) );
-        $found++  if ( $l =~ m|csrf\-token\.inc| && $open );
-        if ( $open && $l =~ m|</form| ) {
+    my $line_number = 0 ;
+    for my $line (@lines) {
+        $line_number++;
+        $open = $line_number if $line =~ m{<form.*method=('|")post('|")}i;
+        $found++ if $open && $line =~ m{csrf-token\.inc};
+        if ( $open && $line =~ m{</form} ) {
             push @errors,
                 "The <form> starting on line $open is missing it's corresponding csrf_token include (see bug 22990)"
                 if !$found;
             $found = 0;
+            undef $open;
         }
     }
     return @errors;
-- 
2.39.5