From fbc21148e73547c0e557f106c02dcedbdcc67807 Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Mon, 17 Jul 2023 12:08:34 -0300
Subject: [PATCH] Bug 34288: Unit tests

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 t/db_dependent/Auth.t | 85 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 83 insertions(+), 2 deletions(-)

diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t
index 4f4ad6a78c..5de81401e1 100755
--- a/t/db_dependent/Auth.t
+++ b/t/db_dependent/Auth.t
@@ -7,7 +7,7 @@ use CGI qw ( -utf8 );
 use Test::MockObject;
 use Test::MockModule;
 use List::MoreUtils qw/all any none/;
-use Test::More tests => 18;
+use Test::More tests => 19;
 use Test::Warn;
 use t::lib::Mocks;
 use t::lib::TestBuilder;
@@ -20,7 +20,10 @@ use Koha::Patrons;
 use Koha::Auth::TwoFactorAuth;
 
 BEGIN {
-    use_ok('C4::Auth', qw( checkauth haspermission track_login_daily checkpw get_template_and_user checkpw_hash ));
+    use_ok(
+        'C4::Auth',
+        qw( checkauth haspermission track_login_daily checkpw get_template_and_user checkpw_hash get_cataloguing_page_permissions )
+    );
 }
 
 my $schema  = Koha::Database->schema;
@@ -1003,3 +1006,81 @@ subtest 'check_cookie_auth overwriting interface already set' => sub {
 };
 
 $schema->storage->txn_rollback;
+
+subtest 'get_cataloguing_page_permissions() tests' => sub {
+
+    plan tests => 6;
+
+    $schema->storage->txn_begin;
+
+    my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { flags => 2**2 } } );    # catalogue
+
+    ok(
+        !C4::Auth::haspermission( $patron->userid, get_cataloguing_page_permissions() ),
+        '"catalogue" is not enough to see the cataloguing page'
+    );
+
+    $builder->build(
+        {
+            source => 'UserPermission',
+            value  => {
+                borrowernumber => $patron->id,
+                module_bit     => 24,               # stockrotation
+                code           => 'manage_rotas',
+            },
+        }
+    );
+
+    t::lib::Mocks::mock_preference( 'StockRotation', 1 );
+    ok(
+        C4::Auth::haspermission( $patron->userid, get_cataloguing_page_permissions() ),
+        '"stockrotation => manage_rotas" is enough'
+    );
+
+    t::lib::Mocks::mock_preference( 'StockRotation', 0 );
+    ok(
+        !C4::Auth::haspermission( $patron->userid, get_cataloguing_page_permissions() ),
+        '"stockrotation => manage_rotas" is not enough when `StockRotation` is disabled'
+    );
+
+    $builder->build(
+        {
+            source => 'UserPermission',
+            value  => {
+                borrowernumber => $patron->id,
+                module_bit     => 13,                     # tools
+                code           => 'manage_staged_marc',
+            },
+        }
+    );
+
+    ok(
+        C4::Auth::haspermission( $patron->userid, get_cataloguing_page_permissions() ),
+        'Having one of the listed `tools` subperm is enough'
+    );
+
+    $schema->resultset('UserPermission')->search( { borrowernumber => $patron->id } )->delete;
+
+    ok(
+        !C4::Auth::haspermission( $patron->userid, get_cataloguing_page_permissions() ),
+        'Permission removed, no access'
+    );
+
+    $builder->build(
+        {
+            source => 'UserPermission',
+            value  => {
+                borrowernumber => $patron->id,
+                module_bit     => 9,                    # editcatalogue
+                code           => 'delete_all_items',
+            },
+        }
+    );
+
+    ok(
+        C4::Auth::haspermission( $patron->userid, get_cataloguing_page_permissions() ),
+        'Having any `editcatalogue` subperm is enough'
+    );
+
+    $schema->storage->txn_rollback;
+};
-- 
2.20.1