From fd258280482e0c84bf6baf61d7054b1c628e53f7 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 31 Oct 2023 13:48:11 +0000
Subject: [PATCH] Bug 35198: Sort database column names alphabetically on
 automatic item modification page

This patch modifies the automatic item modification by age page so that
the rule entry form sorts <select>s alphabetically, making it easier to
find the entry you need.

The [% FOR field IN... %] directives now include the "sort" method, e.g.

    [% FOR field IN agefields.sort %]

To test, apply the patch and go to Cataloging -> Item modifications by
age

- Click the "Add rules" button, then the "Add rule" button.
- Check the "Age field," "Conditions," and "Substitutions" dropdowns to
  confirm that the choices are listed alphabetically.
- Fill in the form and save the rule.
- Go back and edit the rule you created. Check that the dropdowns are
  still correct.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../tools/automatic_item_modification_by_age.tt      | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
index 1ceac4b135..9462f94342 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
@@ -97,7 +97,7 @@
                           <div class="blocks">
                               <select name="agefield_[% id | html %]">
                                   <option value="">Choose an age field</option>
-                                  [% FOR field IN agefields %]
+                                  [% FOR field IN agefields.sort %]
                                     [% IF rule.agefield == field %]
                                      <option value="[% field | html %]" selected="selected">[% field | html %]</option>
                                     [% ELSE %]
@@ -114,7 +114,7 @@
                         <div class="block">
                           <select name="condition_field_[% id | html %]">
                             <option value="">Choose a field name</option>
-                            [% FOR field IN condition_fields %]
+                            [% FOR field IN condition_fields.sort %]
                               [% IF condition.field == field %]
                                 <option value="[% field | html %]" selected="selected">[% field | html %]</option>
                               [% ELSE %]
@@ -135,7 +135,7 @@
                         <div class="block">
                           <select class="required" required="required" name="substitution_field_[% id | html %]">
                             <option value="">Choose a field name</option>
-                            [% FOR field IN substitution_fields %]
+                            [% FOR field IN substitution_fields.sort %]
                               [% IF substitution.field == field %]
                                 <option value="[% field | html %]" selected="selected">[% field | html %]</option>
                               [% ELSE %]
@@ -172,7 +172,7 @@
               <div class="block">
                   <select name="agefield">
                       <option value="">Choose an age field</option>
-                      [% FOR field IN agefields %]
+                      [% FOR field IN agefields.sort %]
                            <option value="[% field | html %]">[% field | html %]</option>
                       [% END %]
                   </select>
@@ -184,7 +184,7 @@
               <div class="block">
                 <select name="condition_field">
                   <option value="">Choose a field name</option>
-                  [% FOR field IN condition_fields %]
+                  [% FOR field IN condition_fields.sort %]
                     <option value="[% field | html %]">[% field | html %]</option>
                   [% END %]
                 </select>
@@ -199,7 +199,7 @@
               <div class="block">
                 <select required="required" class="required" name="substitution_field">
                   <option value="">Choose a field name</option>
-                  [% FOR field IN substitution_fields %]
+                  [% FOR field IN substitution_fields.sort %]
                     <option value="[% field | html %]">[% field | html %]</option>
                   [% END %]
                 </select>
-- 
2.20.1