From fe7f21f1ada0ad2c6420d1425d717f8d5bc67343 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Fri, 17 Jan 2020 10:48:50 +0100 Subject: [PATCH] Bug 24443: Unit test Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ef3c039e5d964da5da8ba253b52a46fffa66ad66) Signed-off-by: Lucas Gass --- t/db_dependent/Items.t | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t index bb731193fa..033b1f60e0 100755 --- a/t/db_dependent/Items.t +++ b/t/db_dependent/Items.t @@ -368,7 +368,7 @@ subtest q{Test Koha::Database->schema()->resultset('Item')->itemtype()} => sub { }; subtest 'SearchItems test' => sub { - plan tests => 14; + plan tests => 15; $schema->storage->txn_begin; my $dbh = C4::Context->dbh; @@ -402,6 +402,7 @@ subtest 'SearchItems test' => sub { homebranch => $library2->{branchcode}, holdingbranch => $library2->{branchcode}, itype => $itemtype->{itemtype}, + issues => 3, }, $biblio->biblionumber); my ($items, $total_results); @@ -543,6 +544,25 @@ subtest 'SearchItems test' => sub { my $cpl_items_after = SearchItemsByField( 'homebranch', $library1->{branchcode}); is( ( scalar( @$cpl_items_after ) - scalar ( @$cpl_items_before ) ), 1, 'SearchItemsByField should return something' ); + # Issues count may be NULL + $filter = { + conjunction => 'AND', + filters => [ + { + field => 'issues', + query => 0, + operator => '=', + }, + { + field => 'homebranch', + query => $library1->{branchcode}, + operator => '=', + }, + ], + }; + ($items, $total_results) = SearchItems($filter); + is($total_results, 1, "Search items.issues is NULL with filter issues = 0"); + $schema->storage->txn_rollback; }; -- 2.39.2