From fecf5c38bb5bd4f0c2777482565ce871562f2ce4 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Thu, 3 Jul 2008 16:27:12 -0500 Subject: [PATCH] bug 2171: removed "Transfers to do" report This hold request and transfer report no longer works now that hold requests are processed via checking items in. This patch removes the report; please consult the koha-devel message re "RFC - remove circ/transferstodo.pl prior to general release" for more details. Signed-off-by: Joshua Ferraro --- circ/transferstodo.pl | 135 ------------------ .../en/modules/circ/circulation-home.tmpl | 1 - .../prog/en/modules/circ/transferstodo.tmpl | 92 ------------ .../en/modules/help/circ/transferstodo.tmpl | 11 -- 4 files changed, 239 deletions(-) delete mode 100755 circ/transferstodo.pl delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstodo.tmpl delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/transferstodo.tmpl diff --git a/circ/transferstodo.pl b/circ/transferstodo.pl deleted file mode 100755 index 1837e331ae..0000000000 --- a/circ/transferstodo.pl +++ /dev/null @@ -1,135 +0,0 @@ -#!/usr/bin/perl - - -# Copyright 2000-2002 Katipo Communications -# -# This file is part of Koha. -# -# Koha is free software; you can redistribute it and/or modify it under the -# terms of the GNU General Public License as published by the Free Software -# Foundation; either version 2 of the License, or (at your option) any later -# version. -# -# Koha is distributed in the hope that it will be useful, but WITHOUT ANY -# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR -# A PARTICULAR PURPOSE. See the GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along with -# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, -# Suite 330, Boston, MA 02111-1307 USA - -use strict; -use C4::Context; -use C4::Output; -use CGI; -use C4::Branch; # GetBranches -use C4::Auth; -use C4::Dates qw/format_date/; -use C4::Circulation; -use C4::Reserves; -use C4::Members; -use Date::Calc qw( - Today - Add_Delta_Days - Date_to_Days -); -use C4::Koha; -use C4::Biblio; -use C4::Items; - -my $input = new CGI; - -my ( $template, $loggedinuser, $cookie ) = get_template_and_user( - { - template_name => "circ/transferstodo.tmpl", - query => $input, - type => "intranet", - authnotrequired => 0, - flagsrequired => { circulate => 1 }, - debug => 1, - } -); - -# set the userenv branch -my $default = C4::Context->userenv->{'branch'}; - -my $item = $input->param('itemnumber'); -my $fbr = $input->param('fbr'); -my $tbr = $input->param('tbr'); - -# If we have a return of the form dotransfer, we launch the subroutine dotransfer -if ($item) { - C4::Circulation::Circ2::ModItemTransfer( $item, $fbr, $tbr ); -} - -# get the all the branches for reference -my $branches = GetBranches(); - -my @branchesloop; -foreach my $br ( keys %$branches ) { - my @reservloop; - my %branchloop; - my @getreserves = - GetReservesToBranch( $branches->{$br}->{'branchcode'} ); - if (@getreserves) { - $branchloop{'branchname'} = $branches->{$br}->{'branchname'}; - $branchloop{'branchcode'} = $branches->{$br}->{'branchcode'}; - foreach my $num (@getreserves) { - my %getreserv; - my $gettitle = GetBiblioFromItemNumber( $num->{'itemnumber'} ); -# use Data::Dumper; -# warn Dumper($gettitle); - my $itemtypeinfo = getitemtypeinfo( $gettitle->{'itemtype'} ); - if ( $gettitle->{'holdingbranch'} eq $default ) { - my $getborrower = - GetMemberDetails( $num->{'borrowernumber'} ); - $getreserv{'reservedate'} = - format_date( $num->{'reservedate'} ); - my ( $reserve_year, $reserve_month, $reserve_day ) = split /-/, - $num->{'reservedate'}; - ( $reserve_year, $reserve_month, $reserve_day ) = - Add_Delta_Days( $reserve_year, $reserve_month, $reserve_day, - C4::Context->preference('ReservesMaxPickUpDelay')); - my $calcDate = - Date_to_Days( $reserve_year, $reserve_month, $reserve_day ); - my $today = Date_to_Days(&Today); - my $warning = ( $today > $calcDate ); - - if ( $warning > 0 ) { - $getreserv{'messcompa'} = 1; - } - $getreserv{'title'} = $gettitle->{'title'}; - $getreserv{'biblionumber'} = $gettitle->{'biblionumber'}; - $getreserv{'itemnumber'} = $gettitle->{'itemnumber'}; - $getreserv{'barcode'} = $gettitle->{'barcode'}; - $getreserv{'itemtype'} = $itemtypeinfo->{'description'}; - $getreserv{'holdingbranch'} = $gettitle->{'holdingbranch'}; - $getreserv{'itemcallnumber'} = $gettitle->{'itemcallnumber'}; - $getreserv{'borrowernum'} = $getborrower->{'borrowernumber'}; - $getreserv{'borrowername'} = $getborrower->{'surname'}; - $getreserv{'borrowerfirstname'} = $getborrower->{'firstname'}; - $getreserv{'borrowermail'} = $getborrower->{'emailaddress'}; - $getreserv{'borrowerphone'} = $getborrower->{'phone'}; - push( @reservloop, \%getreserv ); - } - } - - # If we have a return of reservloop we put it in the branchloop sequence - if (@reservloop) { - $branchloop{'reserv'} = \@reservloop; - } - # else, we unset the value of the branchcode . - else { - $branchloop{'branchcode'} = 0; - } - } - push( @branchesloop, \%branchloop ) if %branchloop; -} - -$template->param( - branchesloop => \@branchesloop, - show_date => format_date(C4::Dates->today('iso')), - dateformat => C4::Context->preference("dateformat"), -); - -output_html_with_http_headers $input, $cookie, $template->output; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tmpl index a2e33aa1fd..7f62cb8268 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tmpl +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tmpl @@ -32,7 +32,6 @@
  • Holds to pull
  • Holds awaiting pickup
  • Hold ratios
  • -
  • Transfers to do
  • Transfers to receive
  • Overdues
  • Overdue fines
  • diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstodo.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstodo.tmpl deleted file mode 100644 index be6db2b9ac..0000000000 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstodo.tmpl +++ /dev/null @@ -1,92 +0,0 @@ - -Koha › Circulation › Transfers to do - - - - - - - - - - -
    - -
    -
    -
    - - -

    Transfers to do,

    - -
    - - -

    Holds waiting for:

    - " style="width:100%;"> - - - - - - - - - - - - - - - - -
    Date of holdTitlePatronLocalisationAction

    Hold over
    -"> - -"> - -">   ( )
    Barcode :
    ">,
    -
    - - ?subject=Reservation: "> - - - -
    -
    - " /> - " /> - " /> - -
    -
    - - -
    - -

    No transfers to do

    - - -
    -
    -
    - diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/transferstodo.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/transferstodo.tmpl deleted file mode 100644 index 259aedf340..0000000000 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/transferstodo.tmpl +++ /dev/null @@ -1,11 +0,0 @@ - - -

    Transfers To Do Help

    What is a Transfer To Do?

    - -

    A Transfer To Do is where a patron in another library/branch has requested an item that is on your shelf. This tells you the items that need to be sent to other libraries/branches.

    - -

    How do you Transfer an Item?

    - -

    To Transfer an item, locate the item on the shelf, ready it for shipping and click the "Transfer This Item" button next to the item. This will change the status of the item to "In Transit" from your branch to the destination branch.

    - - \ No newline at end of file -- 2.20.1