]> git.koha-community.org Git - koha.git/commit
Bug 28290: Don't send subfields to 'as_string' if none to send
authorNick Clemens <nick@bywatersolutions.com>
Tue, 4 May 2021 18:29:05 +0000 (18:29 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Mon, 14 Nov 2022 13:33:09 +0000 (14:33 +0100)
commit68c1318ff6a417e855d1cb6083174d260944760e
tree5f7d96246a732a79bcfcc26f4b92ac7b2cafbbd6
parent560ceab2595470e43fdd4a69d6403c28f1c82dd8
Bug 28290: Don't send subfields to 'as_string' if none to send

This fixes an error where we send a blank string to
Marc::Field->as_string

The subroutine fails as the regex is marked as incomplete as there is
nothing between the brackets

Also fixes a missing hidden input for 'item_action' when no items are
staged during import

 1 - Define a new matching rule with no subfields
    Match-threshold: 1000
    Record type: bibliographic record
    Search-index: Other-control-number
    Score: 1000
    Tag: 035
    Subfields:
    Offset:
    Length:
 2 - Attempt to stage a record with an 035 using this rule (i will
     attach example to bug)
 3 - Staging fails
 4 - Stage again with no matching rule
 5 - Manage the staged record, try to apply the matching rule
 6 - It fails, 500 error
 7 - Apply patch
 8 - Restart all the things
 9 - Apply rule again, it works!
10 - Stage the record again using the rule for matching
11 - It stages and matches!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit eded6edacc5e3bf8dd0be21ed05842c3b78aadce)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 0c8e4780d78c0c90e2fb5d6c08868104a91e1f2c)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
C4/Matcher.pm
koha-tmpl/intranet-tmpl/prog/en/includes/tools-item-action.inc