]> git.koha-community.org Git - koha.git/commit
Bug 31202: Don't remove optional SIP fields with a value of "0"
authorKyle Hall <kyle@bywatersolutions.com>
Wed, 20 Jul 2022 16:32:58 +0000 (12:32 -0400)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Mon, 12 Sep 2022 08:38:08 +0000 (10:38 +0200)
commit6a26ee39ec87022eaa5c66b4a37f803a1e75c811
treece8ff91126dc44ca57dfa69f12fb34834069bc96
parent028ac8d39f967b824a431cf501273aecca30d159
Bug 31202: Don't remove optional SIP fields with a value of "0"

If the value of a SIP field is "0", that evaluates to false, so any calls to maybe_add with a value of "0" will not get added to the SIP response message.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Michal Urban <michalurban177@gmail.com>
JK: Adjust commit title

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 8b957a69d4449bedd0f593cf946e5fde0e8d7a69)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 5775f6c9a97bbfe15c1c496c6b2fdee856734cf1)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
C4/SIP/Sip.pm
t/db_dependent/SIP/Message.t