]> git.koha-community.org Git - koha.git/commit
Bug 36818: Escape characters in file names uploaded
authorChris Cormack <chris@bigballofwax.co.nz>
Wed, 8 May 2024 22:41:43 +0000 (22:41 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 3 Jun 2024 15:20:37 +0000 (15:20 +0000)
commit9c55702c5020b42c3be90441ac103e0981e31e7c
treedbfc8ba4a53ddb841d1f191dc0154528649b4a71
parent70bccecc4c5cd4c3687b7e6bf5da3fbde7852df1
Bug 36818: Escape characters in file names uploaded

To test:
1/ create a file named something like 'execute`curl blog.bigballofwax.co.nz`.zip'
   Where the domain is one you can watch the logs from
2/ Upload this file as a cover image
3/ Check /var/lib/koha/sitename/tmp/koha_sitename/ and see unescaped filenames
4/ Choose process, check the logs of the webserver see the connection has been made
5/ Apply the patch
5/ Repeat 2 & 3 and see the filename is now escaped
6/ Choose process and check no errors but no no remote execution occurs
7/ Test uploading actual zip file and images still works

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/Uploader.pm