Galen Charlton [Fri, 29 May 2009 01:13:21 +0000 (20:13 -0500)]
bug 2884: followup patch
[1] Restore behavior of the input field for the library
code; when adding a new library, it should be a
a text box; when editing an existing library,
should be a hidden input.
[2] When user attempts to add a new library with the same
code as that of an existing library, populate the form
with what the user entered for the new library, not the
values from the existing library.
Paul Poulain [Thu, 28 May 2009 16:32:16 +0000 (18:32 +0200)]
fix for #2884: Add error management to branches
While trying to add a new Branch with an existing Branch code, the UI says "Library saved" instead of something such as "Please select a unique branch code".
Garry Collum [Thu, 28 May 2009 01:48:12 +0000 (21:48 -0400)]
Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.
Added javascript and if/else logic to the addbiblio.tmpl and a corresponding anchor tag in CSS.
If advancedMARCeditor is on, the user now clicks on the tag number to expand the marc fields.
If advancedMARCeditor is off, no functionality has changed. The user clicks on the marc tag's title to expand the marc fields.
Joe Atzberger [Wed, 27 May 2009 18:38:58 +0000 (13:38 -0500)]
Allow option to preserve Extended Attributes on patron import update.
Essentially, this patch provides the option to overwrite only matching
Extended Attributes, instead of all of them, treating the ext. fields more
like normal fields.
Several functions added to Members::Attributes with corresponding tests.
Updated INSTALL.opensuse file to match the one currently (as of 26-May-2009) available in the wiki at:
Installation Guide for Installing Koha 3 on openSUSE 11 - Koha Developer Wiki
http://wiki.koha.org/doku.php?id=opensuse_11.0
This commit is supposed to be applied to the 3.0.x branch.
Changelog:
– Updated last modification date to 02-Dec-2008
– Tried to clarify that one should add the word "rewrite" (without the quotes) to /etc/sysconfig/apache2 in case a2enmod does NOT work
– "make test" does NOT return "Can't connect to data source" errors any longer. Updating "make install" section accordingly
– Updated "make test" output for Koha installation (it doesn't give connect errors any longer)
– Added prompt to accept permanent instlallation of "Test-Manifest-1.22.tar.gz" during "XML::RSS" install
– Installing "XML::RSS" now also installs "Time::y2038"
– Added "force install" of "Barcode::128"
– Added output of "MARC::Charset" installation (that points that it is already up to date)
– Updated "CGI::Session::Serialize::yaml" section that now installs Test::Pod
– Added "MIME::LITE" installation that is new in Koha 3.0 Final
– Removed ImageMagick installation because it's no longer required in Koha 3.0 Final
– Added instructions to install the "GD" Perl module and its package dependencies
– Added "Email::Date" installation that is new in Koha 3.0 Final
– Updated list of prerequisites according to changes done in Koha 3.0 Final
– Added missing step to install yaz. Thanks to Bob Ewart for catching it
– Added explanation of answering Yes to "Install the Zebra configuration files" in a NOZEBRA installation, like this one
– Added explanation of "fr" (French) choice for Koha install
– Promoted run "make install" to Heading 4
Garry Collum [Sun, 24 May 2009 16:10:23 +0000 (12:10 -0400)]
Bug 1687: Can't assign holidays to all branches at once.
This patch adds a select box to the new holiday form that allows the user to copy the holiday to all branches. If a holiday for a particular location already exists for a location, that holiday and location is not changed.
Garry Collum [Mon, 25 May 2009 00:51:18 +0000 (20:51 -0400)]
Bug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.
Added code to detect if the syspref for item-level_itypes is being used. The report now correctly returns data based on the syspref. There are some pre-existing XML errors with the FORM view of catalogue_stats.pl. I'll send a subsequent patch to deal with these.
Joe Atzberger [Fri, 22 May 2009 19:35:35 +0000 (14:35 -0500)]
Cleanup transferstoreceive.pl and .tmpl
Removed unused variables. Replaced EXPR.
Inserted hidden span to correct tablesorter behavior on title field. Without this patch
because of the link href in the cell, the sort would end up being effectively on
biblionumber, not title.
Galen Charlton [Fri, 22 May 2009 12:41:22 +0000 (07:41 -0500)]
followup to previous patch - don't use TMPL_IF EXPR
Because of the way that HTML::Template::Pro evaluates
expressions, any variable referred to in a TMPL_IF EXPR
must be be present when the template is parsed, otherwise
you get Apache error log warnings like this:
non-initialized variable new_subfield
For a simple flag check, TMPL_IF NAME="new_subfield" is sufficient.
Galen Charlton [Thu, 21 May 2009 20:03:57 +0000 (15:03 -0500)]
bug 2897: fix English sample notices
Same as Joe's prior 2897 patch, but applied to the English
sample_notices.sql - due to a Git merge and rename detection
oddity, his original submitted patch was applied to the French
sample_notices.sql. Since the two files are
currently identical, no problem in the end.
Michael Hafen [Wed, 29 Oct 2008 19:48:04 +0000 (13:48 -0600)]
in Auth_with_ldap.pm try binding with user password or compare
This changes the checkpw code in Auth_with_ldap. Along with comparing
the user entered password against the directory attibute userPassword
you can try to bind with the users dn and password.
This is controlled by the option auth_by_bind, which, if set, causes
this code to try binding instead of comparing.
this patch fix the searchorder function, and add to the SQL query a "AND biblionumber" statement if a biblionumber is speficied.
Sometimes C4::Acquisitions::searchorder() find more than one result, so the user is looping to the same page to choose the great record, adding a contraint to biblionumber allows to be more strict.
Joe Atzberger [Wed, 20 May 2009 21:55:09 +0000 (16:55 -0500)]
Cleanup and enhance bookcount.pl and .tmpl
Eliminated bug with date handling outputting an English string.
Row striping added. Highlight for "my branch" row added.
GetBranchesLoop used instead of recreating data structure, so we get the
benefit of branches being sorted (by display name).
Joe Atzberger [Wed, 20 May 2009 19:39:03 +0000 (14:39 -0500)]
Add onlymine helper function.
This should allow scripts to use GetBranchesLoop without having to reproduce
the check for:
(1) IndependantBranches,
(2) User logged in,
(3) User Not superlibrarian, and
(4) User branch set.
Bug 3107. Creation of `permissions` table fails during the web-installation (ru-RU)
ERROR 1452 (23000) at line 3: Cannot add or update a child row: a foreign key constraint fails (`koha/permissions`,
CONSTRAINT `permissions_ibfk_1` FOREIGN KEY (`module_bit`) REFERENCES `userflags` (`bit`) ON DELETE CASCADE ON
UPDATE CASCADE)
Joe Atzberger [Tue, 19 May 2009 18:23:49 +0000 (13:23 -0500)]
Cleanup returns, consolidate some repeated logic.
Use one $userenv_branch instead of many calls to C4::Context->userenv->{'branch'}
for comparisons. Script is not warnings safe yet, but getting closer.
Galen Charlton [Tue, 19 May 2009 12:22:42 +0000 (07:22 -0500)]
bug 3236: remove disused scripts and a function
Removed opac/opac-dictionary.pl and catalogue/dictionary.pl,
which were not in use and not linked to from any active
template files. According to Henri, the functionality that
these scripts implemented hasn't been working since 2.2.
Also removed C4::Search::findseealso(), which was used
only by the two scripts.
Garry Collum [Sun, 17 May 2009 22:20:05 +0000 (18:20 -0400)]
Bug 1768: Calendar now retains the month on which the user was entering data.
If a user adds or edits a holiday, the calendar will now return to the month in which the user was working. Also after an add or an edit, if the user selects another location, the calendar remains in the same month for which the add or edit took place. The user sees a 'calendardate' parameter in the URL in the format that is chosen as the system preference. If an invalid date is entered in the url, the current date is used.
Brian Harrington [Wed, 29 Apr 2009 17:37:06 +0000 (13:37 -0400)]
Revisions to auto-generated authorities patch
It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl. I
also realized I can't count. :-)
Modified per comments by Joe and Galen to keep SetMarcUnicodeFlag
and move it and the leader set to earlier in the process.
Galen Charlton [Thu, 14 May 2009 00:37:17 +0000 (19:37 -0500)]
bug 3223: add 500 and 590 to MARC21 bib Note index (Zebra)
Note: to completely apply this change, ensure that the working
copy of record.abs is updated and rebuild the bib indexes
using rebuild_zebra.pl -b -x -r
Garry Collum [Tue, 12 May 2009 20:53:15 +0000 (16:53 -0400)]
Bug 1440: Show a list of holidays. Second patch.
Fixed XHTML error that was introduced in the first patch. Added zebra striping to the tables. Removed an erroneous line with a date experiment that had no affect on the dates.
Add a date field in news edition, and permit to set the "timestamp" field, that is the publication date and modify the GetNewsToDisplay to return only news that timestamp is < to current date that permit to publish news later without any action.
Owen Leonard [Thu, 30 Apr 2009 16:36:19 +0000 (11:36 -0500)]
More fixes for Bug 2704, 440 Display Issues
Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record.
Galen Charlton [Fri, 8 May 2009 16:54:29 +0000 (11:54 -0500)]
bug 3205: fix another error in the OAI-PMH Identify response
The optional description element of an Identify response
can't just be a string. Identify.description is a container
for one or more elements; see http://www.openarchives.org/OAI/2.0/guidelines.htm
Joe Atzberger [Tue, 28 Apr 2009 23:23:36 +0000 (18:23 -0500)]
Bug 3130 and general cleanup
Javascript error in FF and IE when loading page and no data matches criteria.
This was because it was passing more holds than necessary to the template and
letting a template conditional inside the loop control whether to display or not.
That doesn't make sense, and it forces the table to be displayed even when all
rows FAIL the conditional. jquery.tablesorter was confused trying to be added
on top of an empty table with nothing to sort.
There were several other errors addressed by this patch:
~ 13 unused variables deleted.
~ regexps run on user-supplied $var before checking $var defined
~ decimal ratio prohibited and silently replaced with "3"
I also added the hold ratio to a column display, with a jquery tweak to put it in
the ratio input box on click. Hidden .sql div now contains the actual query run,
like the other wizard reports.
Michael Hafen [Fri, 12 Sep 2008 19:16:58 +0000 (13:16 -0600)]
Use biblioitems.itemtype as a default for items.itype
This correct the html select default in additem.pl, and enforces use of
biblioitems.itemtype as the default in Items::AddItem. The code in
Items is to catch items added through MARC record staging.
Thanks to Joe Atzberger for suggestion.
[RM note: this patch means that an item's item-level item type,
once that item is added or updated via additem.pl,
now cannot be blank or NULL unless the biblio-level item type
is blank.]
Brian Harrington [Tue, 21 Apr 2009 16:13:22 +0000 (12:13 -0400)]
Patch to improve auto-generated MARC21 authorities
This patch makes sure that MARC21 authorities have a minimal
Leader, 008, and 040. If an authority record is created through
BiblioAddsAuthority it generates a 670 based on information in
the bib record.
Change typo Localisation to Localization for Bug # 3102
[RM note: I think there are a few people who wouldn't
call "localisation" a typo - such as our UK, NZ,
Australian, etc. contributors ;-) ]. That said,
I'm pushing this patch to consistent with the
general trend of the English varient used on the
/prog/ templates. There's no implication that en_US
is the "correct" version of the language.]
Owen Leonard [Sun, 29 Mar 2009 23:46:39 +0000 (18:46 -0500)]
Reformatting receipt template and CSS to be more readable.
A narrow printable area is unsuitable for a three-column table of information. Changing to paragraph sections for each item. Also correcting terminology: issue -> checkout
Joe Atzberger [Thu, 9 Apr 2009 16:50:47 +0000 (11:50 -0500)]
Multi-bug fix - SetMarcUnicodeFlag for records coming from Koha
This has bearing on bugs 2905, 2665, 2514 and other "wide character" crashes
related to diacritics and Unicode. This should help open the door for reliable
input of diacriticals via acquisitions.
MARC21_utf8_flag_fix.pl diagnoses and fixes existing problems with MARC data
affected by the bug.
Adding SetMarcUnicodeFlag to TransformKohaToMarc prevents the bug from corrupting
further data.
(bug #3051) bad support of pagination in auth_finder
This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.
Joe Atzberger [Tue, 7 Apr 2009 22:37:49 +0000 (17:37 -0500)]
orderreceive cleanup
Convert to GetBranchesLoop, remove unused variables.
Pull out params that are assigned the same value in each loop and just assign them once.
Pull out params that are assigned the same value in each half of the conditional, and just assign them unconditionally.
Remove useless call of $template->param($count).
Owen Leonard [Thu, 2 Apr 2009 19:06:33 +0000 (14:06 -0500)]
Adding details to OPAC search results RSS, described in Bug 2973.
This includes a change to Search.pm to add a variable, subtitle_nospan, in order to display subtitles in the feed without search term highlighting HTML. The modified template attempts to display Amazon, Syndetics, or Baker & Taylor book cover images. Google images are not included because they require Javascript.
Joshua Ferraro [Thu, 26 Mar 2009 22:09:44 +0000 (17:09 -0500)]
Adds a 'New Subscription' option for selection from the detail page of a record.
NOTE TO DOCUMENTATION WRITERS: Due to the limitations in the serials module search
interface, some users may find it easier to use the standard catalog search to locate
an item on which to create a subscription record, and then use this new button to
create a subscription from the detail page.
Michael Hafen [Tue, 24 Feb 2009 19:05:50 +0000 (12:05 -0700)]
Add option to inventory tool to ignore copies on loan
This adds an option to the inventory tool causing it to ignore copies
currently on loan. This is good if you want to do inventory, but don't
want to update the date-last-seen on items currently on loan.
Galen Charlton [Fri, 9 Jan 2009 18:16:43 +0000 (12:16 -0600)]
bug 2505: more warnings fixes in C4/Context.pm
* more portable way to determine uname for
crash messages
* C4::Context->userenv now returns undef instead
of 0 if no userenv has been set yet; returning
undef when necessary is almost always better
than returning a scalar when a hashref is
normally expected.
Joe Atzberger [Thu, 8 Jan 2009 03:47:36 +0000 (21:47 -0600)]
Bug 2900: fix GetPendingIssues.
GetPendingIssues did several bad things:
~ select * on a 4 table join,
~ including multiple namespace collisions,
~ including large fields marc and marcxml from biblioitems,
~ return ($count, \@array_being_counted).
Not everything is fixed here (see FIXMEs), but the situation is
improved considerably, with bug 2900 resolved. The "timestamp"
namespace collision in query should be resolved by separate patch.
Owen Leonard [Tue, 4 Nov 2008 16:21:47 +0000 (10:21 -0600)]
Fix for Bug 2700, Keeping Data When Adding Multiple Items
When cloning the set of inputs, the new js
increments the IDs of each form field (to keep them unique) and automatically
selects the option that was selected in the cloned group.
projects / koha.git / log