From d67ab2337308eae7921273f08dbfa94581b59e58 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 11 Oct 2023 13:55:42 +0000 Subject: [PATCH] Bug 25393: (QA follow-up) Report 'too_soon' errors from cron This patchset made it possible for 'too_soon' to be returned instead of 'auto_too_soon' - we just need to take that into account in the error listing To test: 1 - Set circ rule to no renewal before 2, no auto renewal before 3 2 - Checkout 3 items with auto renew, due tomorrow, in 2 days, in 3 days 3 - perl misc/cronjobs/automatic_renewals.pl -v 4 - Confirm 1 can be renewed, 1 is too soon, 1 is auto too soon Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi --- misc/cronjobs/automatic_renewals.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl index 4fa83566a8..8115afee7c 100755 --- a/misc/cronjobs/automatic_renewals.pl +++ b/misc/cronjobs/automatic_renewals.pl @@ -205,6 +205,7 @@ while ( my $auto_renew = $auto_renews->next ) { $error eq 'auto_too_late' || $error eq 'auto_too_much_oweing' || $error eq 'auto_too_soon' || + $error eq 'too_soon' || $error eq 'item_denied_renewal' || $error eq 'item_issued_to_other_patron' ) { -- 2.39.5