]> git.koha-community.org Git - koha.git/commit
Bug 16760: fix Circulation Statistics wizard under Plack
authorGalen Charlton <gmcharlt@gmail.com>
Tue, 5 Jul 2016 16:22:39 +0000 (16:22 +0000)
committerJulian Maurice <julian.maurice@biblibre.com>
Tue, 16 Aug 2016 14:19:13 +0000 (16:19 +0200)
commit44805f49cb32455e3680ae923012a2e5e9202a16
tree214f56dcd58a2d6699a6d80d11b17f8b5eb38075
parentd63ca62f87641876e39731fd17e7a90e30e3f81f
Bug 16760: fix Circulation Statistics wizard under Plack

This patch fixes some variable scoping problems when running
the circulation statistics wizard under Plack.  For example,
when using the item type as a row header, with this patch the
item type description is displayed rather than "UKNOWN VALUE".

This patch also enables warnings and fixes a couple variable
initialization issues. (Note that turning on warnings across
the board would make it easier to identify Plack variable scoping
issues, as "Variable "$foo" is not available at' errors would
be recorded in the Plack error log).

To test
-------
[1] Run the staff interface under Plack.
[2] Go to the Circulation Statistics Wizard and run a report
    using item type as the row. Note that the row labels
    display as "UNKNOWN VALUE" rather than the item type.
[3] Apply the patch and restart Plack.
[4] Run step #2 again; this time, the item type descriptions should
    be used as the row labels.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 8ca55a7fb37ac50103de978f82408776fc06b7bb)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(cherry picked from commit 01b0fe1aa85364611b93eafd7f30a2665a228e3c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
reports/issues_stats.pl