From cd8fc9afcdf6a9c0b8420882ac32e81db9ecfd72 Mon Sep 17 00:00:00 2001
From: Mark Tompsett <mtompset@hotmail.com>
Date: Wed, 1 Jun 2016 20:43:30 -0400
Subject: [PATCH] Bug 16636: t/00-load.t warning from
 C4/External/BakerTaylor.pm
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Since the tests are expecting an initialize function, the
initialize call was just moved outside of the INIT block.

TEST PLAN
---------
1) prove t/00-load.t
   -- warnings about INIT for BakerTaylor
2) prove `git grep -l BakerTaylor | grep [.]t$`
   -- should all run okay
3) apply patch
4) repeat steps 1 and 2
   -- warning should be gone, and everything else run okay
5) run koha qa test tools

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>

Signed-off-by: Florent Mara <florent.mara@gmail.com>

NOTE: Tweaked test plan based on comment #4,
      Added sign off based on comment #6.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b4479624de2010fff8851732e94d086b2cca6921)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(cherry picked from commit 9c7c4f02ddad4045fde7ecf68c03389bb6f10436)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
---
 C4/External/BakerTaylor.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/C4/External/BakerTaylor.pm b/C4/External/BakerTaylor.pm
index a869ed5817..6aa5f2ec5f 100644
--- a/C4/External/BakerTaylor.pm
+++ b/C4/External/BakerTaylor.pm
@@ -29,6 +29,7 @@ use warnings;
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
 use vars qw($user $pass $agent $image_url $link_url);
+&initialize;
 
 BEGIN {
 	require Exporter;
@@ -37,9 +38,6 @@ BEGIN {
 	@EXPORT_OK = qw(&availability &content_cafe &image_url &link_url &http_jacket_link);
 	%EXPORT_TAGS = (all=>\@EXPORT_OK);
 }
-INIT {
-	&initialize;
-}
 
 sub initialize {
 	$user     = (@_ ? shift : C4::Context->preference('BakerTaylorUsername')    ) || ''; # LL17984
-- 
2.39.5